Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checker for Tcl #1365

Merged
merged 3 commits into from Nov 26, 2017
Merged

Add new checker for Tcl #1365

merged 3 commits into from Nov 26, 2017

Conversation

bsless
Copy link
Contributor

@bsless bsless commented Nov 26, 2017

Add new checker for Tcl

Add new checker for Tcl and general support for Tcl, including simple test file.

Also fix tiny grammatical error in a comment.

Ben Sless added 2 commits November 26, 2017 17:38
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cpitclaudel cpitclaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Do you think you could add an entry in CHANGES? :)

@bsless
Copy link
Contributor Author

bsless commented Nov 26, 2017

Thanks!
This is my first pull request and I'm still figuring things out, so, I'd love to add any entry you'd like if you could point me to the relevant location

Copy link
Contributor Author

@bsless bsless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds support for the Nagelfar Tcl syntax checker, revert change to PIP path to work on local machine

@cpitclaudel
Copy link
Member

Thanks to you! And welcome aboard :)
The change log is here: https://github.com/flycheck/flycheck/blob/master/CHANGES.rst. You can edit it like the other files.

Add new checker to CHANGES
@bsless
Copy link
Contributor Author

bsless commented Nov 26, 2017

Thanks for the direction, got it figured out eventually 😄
Seems like some tests fail due to disk quota. Do they need to be run again?

@cpitclaudel cpitclaudel merged commit d2b3c32 into flycheck:master Nov 26, 2017
@cpitclaudel
Copy link
Member

Sorry about the tests ! They're all good now.
Great job on your first Flycheck PR! Let's hope there'll be plenty more ^^

@bsless
Copy link
Contributor Author

bsless commented Nov 27, 2017

Thank you! It's been lots of fun, and your directions were helpful.
I hope to find more opportunities to contribute 😃
Can I close the branch now?

@bsless bsless deleted the tcl-nagelfar branch November 27, 2017 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants