Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checker for Tcl #1365

Merged
merged 3 commits into from Nov 26, 2017

Conversation

@bsless
Copy link
Contributor

commented Nov 26, 2017

Add new checker for Tcl

Add new checker for Tcl and general support for Tcl, including simple test file.

Also fix tiny grammatical error in a comment.

Ben Sless added some commits Nov 26, 2017

Ben Sless Ben Sless
Add new checker for Tcl
Add Nagelfar checker for Tcl
Ben Sless Ben Sless
@CLAassistant

This comment has been minimized.

Copy link

commented Nov 26, 2017

CLA assistant check
All committers have signed the CLA.

@cpitclaudel
Copy link
Member

left a comment

Looks great, thanks! Do you think you could add an entry in CHANGES? :)

@bsless

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2017

Thanks!
This is my first pull request and I'm still figuring things out, so, I'd love to add any entry you'd like if you could point me to the relevant location

@bsless
Copy link
Contributor Author

left a comment

Adds support for the Nagelfar Tcl syntax checker, revert change to PIP path to work on local machine

@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

Thanks to you! And welcome aboard :)
The change log is here: https://github.com/flycheck/flycheck/blob/master/CHANGES.rst. You can edit it like the other files.

Add description of new checker to CHANGES
Add new checker to CHANGES
@bsless

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2017

Thanks for the direction, got it figured out eventually 😄
Seems like some tests fail due to disk quota. Do they need to be run again?

@cpitclaudel cpitclaudel merged commit d2b3c32 into flycheck:master Nov 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

Sorry about the tests ! They're all good now.
Great job on your first Flycheck PR! Let's hope there'll be plenty more ^^

@bsless

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2017

Thank you! It's been lots of fun, and your directions were helpful.
I hope to find more opportunities to contribute 😃
Can I close the branch now?

@bsless bsless deleted the bsless:tcl-nagelfar branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.