-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MarkdownLint CLI checker #1366
Conversation
f4ee5f6
to
f2451c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good :) Thanks! Could you add an entry in CHANGES?
f2451c5
to
5d8da07
Compare
@cpitclaudel Done! |
Thanks! One last thing: you should use |
5d8da07
to
c48ca26
Compare
Oops, fixed! |
c48ca26
to
e361648
Compare
CHANGES.rst
Outdated
======================= | ||
========================= | ||
32-cvs (in development) | ||
========================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it was necessary to restyle every headings. But I guess it's your mode that made the change sneakily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yes, I didn't even catch that myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Great! We just need you to squash your commits before we can merge :) |
@fmdkdd Memo to self, never edit code on GitHub. :/ |
Adds support for the MarkdownLint Command Line Interface based on the Node.js markdownlint package. - https://github.com/igorshubovych/markdownlint-cli
0b8a3e5
to
3975864
Compare
@dholm Thanks. One last thing: how does |
@fmdkdd I used mdl at first but had issues with suppressions not working according to the documentation, for instance disabling the line-length check for tables. markdownlint-cli appears to be better maintained and did not have these issues. |
Ping @marsam , any opinions on changing the default checker? :) |
Sorry for the late response, I don't have any issues with changing |
@cpitclaudel Thank you! Isn't it already the default though? I thought the order in |
Adds support for the MarkdownLint Command Line Interface based on the
Node.js markdownlint package.