Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent stack from installing GHC #1443

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

fmdkdd
Copy link
Member

@fmdkdd fmdkdd commented Apr 1, 2018

This should fix #1417.

Although since we have an ignore-errors in there, I'm not sure what happens if stack cannot find GHC. Probably output is nil, then we return the location of the cabal file, if any.

Maybe we need to pass --no-install-ghc to the stack invocation in haskell-stack-ghc as well?

WDYT @flycheck/haskell ?

@purcell
Copy link
Member

purcell commented Apr 1, 2018

Maybe we need to pass --no-install-ghc to the stack invocation in haskell-stack-ghc as well?

Yes, I'd suggest adding that to any checker which uses stack.

@fmdkdd fmdkdd force-pushed the fix-1417-freeze-opening-haskell-file branch from 255e4cc to cfb167a Compare April 13, 2018 09:06
@fmdkdd
Copy link
Member Author

fmdkdd commented Apr 20, 2018

@flycheck/haskell Updated. Do you think we can land this?

Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% convinced that on-demand GHC installation was the root of the related issue, but this is at least harmless, so I'll go ahead and merge it.

@purcell purcell merged commit 539fa19 into master Apr 20, 2018
@fmdkdd fmdkdd deleted the fix-1417-freeze-opening-haskell-file branch April 20, 2018 08:54
fmdkdd added a commit that referenced this pull request Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emacs freezes when opening up a haskell file with flycheck on
2 participants