Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enhance `verify-setup` buffer #1478
Here are some screenshots:
The checker that will effectively run is the first, and the available checkers for the buffer are below. Note that the first checker is not repeated in the available checkers. You can also see the new
Here is what it looks like with larger chains:
I've added two checkers
And the last example is for a buffer without any checker:
Thanks, the screenshot look very nice. Should we also show the other checkers in the current chain in the first section? We often run more than one checker on a single buffer, so it seems misleading to highlight just the first one.
In the past we've also discussed clarifying 'automatically disabled' vs 'may enable': maybe we could add an 'enable now' link next to 'may enable'? An in fact, if we do that, we could remove that line entirely and only show the 'enable now' link next to the thing that says 'automatically disabled'?
I tend to agree. I can put them in sequence, although it might be misleading since we cannot know if all checkers will be run (depending on the value of
2 times, most recently
Jul 19, 2018
cpitclaudel left a comment
Phew, finally found the time to review this. Great work as usual. I hope the comments will be helpful; I'm happy to get this merged after applying the ones you find relevant.
@cpitclaudel I made some changes. Now we display:
Thanks for the update. I just gave it a try. It looks great.