New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ghdl option for setting IEEE library standard. #1547
Conversation
It looks like the CI is failing because I'm missing some documentation. How do I correct this? |
I corrected the documentation issue, however during the integration tests, it looks like the ghdl binary is missing in the builder image. |
Depends on how common it is to use it. The default should be helpful, but not annoying. I don't use GHDL so I'll let you decide. Leave it nil is fine.
Yep, I ran out of steam when I first built the image. Help is always welcome though ;) |
I might add ghdl to the builder image in another PR whenever I have the time. What would I need to edit to make this change? |
See https://github.com/flycheck/docker-tools#how-to-add-a-tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor change.
Could you add a line documenting this option to CHANGES.rst
as well?
The CI is failing due to unrelated Go changes. I'll fix that on master; you'll need to rebase once that is done. |
Rebased onto master and added those changes. Should I squash all these commits into one? |
@wastevensv Yes please, do squash the commits. |
|
Thanks @wastevensv ! |
Adds a common option to the syntax checker for VHDL, to specify which IEEE standard library to use. A typcial value is "--ieee=synopsys". I'm not sure if I should set that as the default, or leave it nil.