Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ghdl option for setting IEEE library standard. #1547

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@wastevensv
Copy link
Contributor

commented Mar 4, 2019

Adds a common option to the syntax checker for VHDL, to specify which IEEE standard library to use. A typcial value is "--ieee=synopsys". I'm not sure if I should set that as the default, or leave it nil.

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 4, 2019

CLA assistant check
All committers have signed the CLA.

@wastevensv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

It looks like the CI is failing because I'm missing some documentation. How do I correct this?

@wastevensv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

I corrected the documentation issue, however during the integration tests, it looks like the ghdl binary is missing in the builder image.

doc/languages.rst Outdated Show resolved Hide resolved
flycheck.el Outdated Show resolved Hide resolved
flycheck.el Outdated Show resolved Hide resolved
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

I'm not sure if I should set that as the default, or leave it nil.

Depends on how common it is to use it. The default should be helpful, but not annoying. I don't use GHDL so I'll let you decide. Leave it nil is fine.

it looks like the ghdl binary is missing in the builder image.

Yep, I ran out of steam when I first built the image. Help is always welcome though ;)

@wastevensv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

I might add ghdl to the builder image in another PR whenever I have the time. What would I need to edit to make this change?

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

What would I need to edit to make this change?

See https://github.com/flycheck/docker-tools#how-to-add-a-tool

@fmdkdd
Copy link
Member

left a comment

LGTM, one minor change.

Could you add a line documenting this option to CHANGES.rst as well?

flycheck.el Outdated Show resolved Hide resolved
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

The CI is failing due to unrelated Go changes. I'll fix that on master; you'll need to rebase once that is done.

@wastevensv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

Rebased onto master and added those changes. Should I squash all these commits into one?

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@wastevensv Yes please, do squash the commits.

@fmdkdd

fmdkdd approved these changes Mar 19, 2019

@cpitclaudel cpitclaudel merged commit 49a0db1 into flycheck:master Mar 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

👍 🎉

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Thanks @wastevensv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.