Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'go tool vet' to 'go vet' #1548

Merged
merged 3 commits into from Mar 8, 2019

Conversation

@vincekd
Copy link
Contributor

commented Mar 6, 2019

[fixes #1523]

Update command/docs/checks to replace go tool vet with go vet.

Removed deprecated command options/flycheck variables

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 6, 2019

CLA assistant check
All committers have signed the CLA.

flycheck.el Outdated Show resolved Hide resolved
@fmdkdd
Copy link
Member

left a comment

Thanks for taking the time to do this! This is a great help.

Two minor changes and one question. In the meantime, I've bumped the CI to use 1.12 when testing.

flycheck.el Outdated Show resolved Hide resolved
flycheck.el Show resolved Hide resolved
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Good, just one minor change in the tests in order to pass the CI now. See here, there's a stray IDENT in the output that should be removed from there.

@andyafter

This comment has been minimized.

Copy link

commented Mar 8, 2019

Just asking, when will this be merged? Needing this desparately

@fmdkdd

fmdkdd approved these changes Mar 8, 2019

@fmdkdd fmdkdd merged commit c51e847 into flycheck:master Mar 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

LGTM. Thank you @vincekd!

@vincekd vincekd deleted the vincekd:fix/go-vet branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.