Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json-jq checker #1568

Merged
merged 5 commits into from May 3, 2019

Conversation

@wbolster
Copy link
Contributor

commented May 2, 2019

This adds a JSON checker using the jq tool.

This checker accepts multiple consecutive JSON values in a single
input, which is useful for jsonlines data.

See https://stedolan.github.io/jq/.

Add json-jq checker
This adds a JSON checker using the jq tool.

This checker accepts multiple consecutive JSON values in a single
input, which is useful for jsonlines data.

See https://stedolan.github.io/jq/.
@CLAassistant

This comment has been minimized.

Copy link

commented May 2, 2019

CLA assistant check
All committers have signed the CLA.

@fmdkdd
Copy link
Member

left a comment

Good idea.

Can you add an integration test in test/flycheck-test.el? We'll also need to add jq to the Docker image.

Please also add a line to CHANGES.rst advertising the new checker.

@wbolster

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

sure, please assign this issue to me, @fmdkdd

@wbolster

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Can you add an integration test in test/flycheck-test.el?

done in 260e5df

We'll also need to add jq to the Docker image.

sure: flycheck/docker-tools#3

Please also add a line to CHANGES.rst advertising the new checker.

done in 3c93f6c and b45265e

@fmdkdd please review again.

@fmdkdd

fmdkdd approved these changes May 3, 2019

@fmdkdd fmdkdd merged commit b6e2a20 into flycheck:master May 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Perfect! Thanks 👍.

@wbolster wbolster deleted the wbolster:add-json-jq-checker branch May 3, 2019

@wbolster

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

that was fast. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.