Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform checkers #1586

Merged
merged 2 commits into from Jun 19, 2019
Merged

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Jun 19, 2019

Hi, I've added checkers for terraform

Tests:

make SELECTOR='(tag checker-terraform)' integ
make SELECTOR='(tag checker-terraform)' integ
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck.el
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck-ert.el
cask exec emacs -Q --batch -L .  --load test/flycheck-test --load test/run.el -f flycheck-run-tests-main '(and (tag external-tool) (tag checker-terraform))'
Loading /Users/marsam/code/flycheck/.cask/26.2/elpa/julia-mode-20190407.2119/julia-latexsubs...
Running tests on Emacs 26.2, built at 2019-06-18
Running 1 tests (2019-06-18 22:01:19-0500)
   passed  1/1  flycheck-define-checker/terraform/default

Ran 1 tests, 1 results as expected (2019-06-18 22:01:20-0500)
make SELECTOR='(tag checker-terraform-tflint)' integ
make SELECTOR='(tag checker-terraform-tflint)' integ
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck.el
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck-ert.el
cask exec emacs -Q --batch -L .  --load test/flycheck-test --load test/run.el -f flycheck-run-tests-main '(and (tag external-tool) (tag checker-terraform-tflint))'
Loading /Users/marsam/code/flycheck/.cask/26.2/elpa/julia-mode-20190407.2119/julia-latexsubs...
Running tests on Emacs 26.2, built at 2019-06-18
Running 1 tests (2019-06-18 22:02:06-0500)
   passed  1/1  flycheck-define-checker/terraform-tflint/default

Ran 1 tests, 1 results as expected (2019-06-18 22:02:08-0500)

fmdkdd
fmdkdd approved these changes Jun 19, 2019
Copy link
Member

@fmdkdd fmdkdd left a comment

LGTM. Thanks!

@cpitclaudel ?

@cpitclaudel cpitclaudel merged commit 8970b2f into flycheck:master Jun 19, 2019
2 checks passed
@cpitclaudel
Copy link
Member

@cpitclaudel cpitclaudel commented Jun 19, 2019

Superb :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants