Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `flycheck-eslint-config-exists-p` for ESLint 6 #1588

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@dywedir
Copy link
Contributor

commented Jun 23, 2019

See eslint/eslint#11885

Since v4.1.0, ESLint has supported glob-based configuration. So --print-config with a directory path doesn't make sense anymore. Configurations are not per directory.

flycheck.el Outdated Show resolved Hide resolved

thomasf added a commit to thomasf/dotfiles-thomasf-emacs that referenced this pull request Jun 28, 2019

@fmdkdd

fmdkdd approved these changes Jul 3, 2019

Copy link
Member

left a comment

LGTM.

@fmdkdd fmdkdd closed this Jul 3, 2019

@fmdkdd fmdkdd reopened this Jul 3, 2019

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Hmm Travis is acting up. Can you refill the code so it stays within 80 chars? This may also trigger a build.

flycheck.el Show resolved Hide resolved

@fmdkdd fmdkdd merged commit 1555b18 into flycheck:master Jul 9, 2019

1 check passed

license/cla All CLA requirements met.
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

In the end Travis did not manage to see this PR for some reason. Had to force the merge after I tested it out locally.

@dywedir

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Thanks!

@dywedir dywedir deleted the dywedir:patch-1 branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.