Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel checker with buildifier #1613

Merged
merged 1 commit into from Aug 21, 2019
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 18, 2019

Add bazel checker with buildifier

make SELECTOR='(tag checker-bazel-buildifier)' integ
make SELECTOR='(tag checker-bazel-buildifier)' integ
cask exec emacs -Q --batch -L .  --load test/flycheck-test --load test/run.el -f flycheck-run-tests-main '(and (tag external-tool) (tag checker-bazel-buildifier))'
Loading /Users/mariorodas/src/flycheck/.cask/26.2/elpa/julia-mode-20190813.1326/julia-latexsubs...
Running tests on Emacs 26.2, built at 2019-08-18
Running 2 tests (2019-08-18 09:12:57-0500)
Can't guess python-indent-offset, using defaults: 4
Can't guess python-indent-offset, using defaults: 4
   passed  1/2  flycheck-define-checker/bazel-buildifier/default
Can't guess python-indent-offset, using defaults: 4
Can't guess python-indent-offset, using defaults: 4
   passed  2/2  flycheck-define-checker/bazel-buildifier/error

Ran 2 tests, 2 results as expected (2019-08-18 09:12:59-0500)

fmdkdd
fmdkdd approved these changes Aug 21, 2019
Copy link
Member

@fmdkdd fmdkdd left a comment

LGTM.

Your contributions are always impeccable @marsam. Would like to become a member of the Flycheck organization? You would have the rights to review and merge PRs. You wouldn't have to contribute any more than you do now, if that's a concern. I just think that, due the quality and frequency of your contributions, it's as if you were already one, so it makes sense to make it official.

@fmdkdd fmdkdd merged commit 52ddbfc into flycheck:master Aug 21, 2019
2 checks passed
@cpitclaudel
Copy link
Member

@cpitclaudel cpitclaudel commented Aug 21, 2019

Your contributions are always impeccable @marsam.

👍

@marsam
Copy link
Contributor Author

@marsam marsam commented Aug 21, 2019

Thanks, I really appreciate your kind words

Would like to become a member of the Flycheck organization?

Sure, I'll be glad to help

@marsam marsam deleted the add-bazel-buildifier branch Aug 21, 2019
@cpitclaudel
Copy link
Member

@cpitclaudel cpitclaudel commented Aug 21, 2019

Sure, I'll be glad to help

Wonderful news! Welcome aboard :) We're delighted to have you.

@fmdkdd
Copy link
Member

@fmdkdd fmdkdd commented Aug 22, 2019

Sure, I'll be glad to help

Glad to hear! I've sent you an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants