New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spuriously change checkers #817

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mkpankov
Contributor

mkpankov commented Dec 7, 2015

Currently when editing the buffer, flycheck temporarily switches to rust checker as the buffer is not saved. It introduces misleading errors about not being able to find crates and is inconsistent overall.

Don't spuriously change checkers
Currently when editing the buffer, flycheck temporarily switches to `rust` checker as the buffer is not saved. It introduces misleading errors about not being able to find crates and is inconsistent overall.
@mkpankov

This comment has been minimized.

Contributor

mkpankov commented Dec 7, 2015

The Travis error doesn't make sense to me; maybe it's a random fluke?

@lunaryorn lunaryorn added the ready label Dec 9, 2015

@lunaryorn lunaryorn self-assigned this Dec 9, 2015

@lunaryorn lunaryorn added the kind: bug label Dec 9, 2015

@s3bs

This comment has been minimized.

Contributor

s3bs commented Dec 9, 2015

@mkpankov You have an outdated .travis.yml file, that had an error. See commit SHA: d402ef8

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Dec 9, 2015

@s3bs @mkpankov Yes, sorry, that was my fault 😞

Never mind the Travis error, the PR is simple enough. I'll just run my rust tests locally with this change, and merge it if they don't break.

@lunaryorn lunaryorn added in progress and removed ready labels Dec 12, 2015

@lunaryorn lunaryorn closed this in 4d184f5 Dec 12, 2015

@lunaryorn lunaryorn removed the in progress label Dec 12, 2015

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Dec 12, 2015

Merged. Thank you very much for this contribution! :)

@mkpankov mkpankov deleted the mkpankov:patch-1 branch Dec 13, 2015

@mkpankov

This comment has been minimized.

Contributor

mkpankov commented Dec 13, 2015

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment