Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never show error buffer in currently active window #822

Closed
wants to merge 1 commit into from

Conversation

@cpitclaudel
Copy link
Member

@cpitclaudel cpitclaudel commented Dec 16, 2015

Investigating #648 led me to another small bug, I think. This should fix it, but since I'm not too familiar with window configuration stuff I'd like a second opinion :)

In short, the error message buffer is sometimes opened in the current window, masking the source code buffer. To reproduce:

  • Follow the instructions in #648 (including the checker definition) and open test1.txt
  • Wait for the error buffer to pop up
  • Move to the window displaying the error buffer with C-x o
  • Display test1.txt in that buffer as well (using C-x b)
  • Wait for the error buffer to pop up again.

On my machine, without the patch, the error buffer pops up and replaces the source buffer that the point was in:

bug

Btw, how do you record good gifs?

@lunaryorn
Copy link
Contributor

@lunaryorn lunaryorn commented Dec 16, 2015

I'll take a look.

@lunaryorn
Copy link
Contributor

@lunaryorn lunaryorn commented Dec 19, 2015

Looks good to me, even though the meaning of this argument is pretty obscure 😕 I've cherry-picked the commit to master, and deleted the branch.

Thank you very much for fixing all these glitches in with the error message buffer, that's really awesome work! ❤️

@lunaryorn lunaryorn deleted the not-this-window branch Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants