Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right syntax table for Emacs Lisp checkdoc #845

Closed
wants to merge 1 commit into from

Conversation

cpitclaudel
Copy link
Member

Looks like with-syntax-table is enough :)
Fixes #833

@@ -3844,7 +3851,7 @@ See https://github.com/flycheck/flycheck/issues/531 and Emacs bug #19206"))
"the function ‘dummy-package-foo’ is not known to be defined.")
:checker emacs-lisp)))

(flycheck-ert-def-checker-test emacs-lisp emacs-lisp sytnax-error
(flycheck-ert-def-checker-test emacs-lisp emacs-lisp syntax-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh 😊 Thanks for fixing that :)

@@ -6224,6 +6224,9 @@ See Info Node `(elisp)Byte Compilation'."
(defconst flycheck-emacs-lisp-checkdoc-form
(flycheck-prepare-emacs-lisp-form
(require 'checkdoc)
;; elisp-mode provides the elisp syntax table
(unless (require 'elisp-mode nil t)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpitclaudel I prefer to use symbols for non-nil arguments, i.e. (require … … 'no-error), because that's easier to read than the meaningless t :)

I'll change that before merging :)

@swsnr
Copy link
Contributor

swsnr commented Jan 6, 2016

@cpitclaudel Merged with some slight modifications, see 7dd0c87. I deleted the branch.

Thank you very much for discovering and fixing this issue! 👍

@swsnr swsnr deleted the fix-833 branch January 6, 2016 13:38
@cpitclaudel
Copy link
Member Author

Beautiful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants