New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a configurable puppet-lint config file #846

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dchenbecker
Contributor

dchenbecker commented Jan 8, 2016

I have several puppet repos I work on, some with different configurations for puppet-lint. I'm adding some rudimentary support for a customizable puppet-lint configuration file so that I can set it in a dir-locals file on a per-project basis.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jan 8, 2016

@dchenbecker Great, thank you very much for this addition. If you don't mind, may I ask you to add this new option to the Puppet section of doc/languages.texi so that it's properly documented? That'd be awesome 😊

@dchenbecker

This comment has been minimized.

Contributor

dchenbecker commented Jan 8, 2016

Sure thing. I was trying to figure out the contributor guide: should I amend my existing commit or make a second commit with the doc changes?

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jan 8, 2016

@dchenbecker Please amend the existing commit if possible.

@dchenbecker dchenbecker force-pushed the dchenbecker:add-support-puppet-lint-rc branch from edf87ba to 7e4fdc2 Jan 8, 2016

@dchenbecker

This comment has been minimized.

Contributor

dchenbecker commented Jan 8, 2016

@lunaryorn Doc fix in place!

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jan 9, 2016

@dchenbecker Thank you very much for this change. Cherry picked on master :)

@lunaryorn lunaryorn closed this in df7687f Jan 9, 2016

@lunaryorn lunaryorn removed the S-ready label Jan 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment