Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix haskell-module-re to exclude following paren #848

Closed
wants to merge 1 commit into from

Conversation

@fizbin
Copy link
Contributor

commented Jan 9, 2016

It is legal and not overly uncommon in haskell to start a module with:

module Foo.Bar(
  quux,
  baz) where

That is, the module name can be terminated with an open paren as well as with a space.

Fix haskell-module-re to exclude following paren
It is legal and not overly uncommon in haskell to start a module with:

    module Foo.Bar(
      quux,
      baz) where

That is, the module name can be terminated with an open paren as well as with a space.

@lunaryorn lunaryorn added the kind: bug label Jan 9, 2016

@lunaryorn

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2016

Oh what a blunder of mine; thank you very much for finding and fixing this. 😔 ☺️

Would you mind to add a test case for this to flycheck-test.el? It's totally fine if you don't want to; I'll add it then.

@lunaryorn lunaryorn self-assigned this Jan 9, 2016

@lunaryorn lunaryorn closed this in 56d8e4d Jan 10, 2016

@lunaryorn lunaryorn removed the S-blocked label Jan 10, 2016

lunaryorn added a commit that referenced this pull request Jan 10, 2016

Fix haskell-module-re to exclude following paren
It is legal and not overly uncommon in haskell to start a module with:

    module Foo.Bar(
      quux,
      baz) where

That is, the module name can be terminated with an open paren as well as
with a space.

Closes GH-848
@lunaryorn

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2016

@fizbin I've merged your patch. Thank you very much! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.