Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .perlcritic support #851

Closed
wants to merge 1 commit into from
Closed

Add .perlcritic support #851

wants to merge 1 commit into from

Conversation

mdorman
Copy link
Contributor

@mdorman mdorman commented Jan 11, 2016

It operates in the same way most of these files do, so just re-use the
standard support for this sort of thing.

@swsnr
Copy link
Contributor

swsnr commented Jan 11, 2016

@mdorman Thank you very much. Would you mind to add this option to doc/languages.texi so that it's properly documented in the manual?

@mdorman
Copy link
Contributor Author

mdorman commented Jan 11, 2016

Oh, yeah, sure. Gimme a moment.

It operates in the same way most of these files do, so just re-use the
standard support for this sort of thing.
@cpitclaudel
Copy link
Member

Seconded, thanks a lot for your contribution!

@mdorman
Copy link
Contributor Author

mdorman commented Jan 11, 2016

So this is quite literally the first time I've ever written any .texi, so I just copied the usage from elsewhere. Please let me know if I fat-fingered something.

It also wasn't obvious to me where best to put it, so I stashed it in alpha order with the other options.

@swsnr
Copy link
Contributor

swsnr commented Jan 11, 2016

@mdorman Thank you very much, you've done it all right, alphabetical order is exactly how we try to do it :) 👍 I cherry-picked your commit to master. Thanks for your contribution!

@mdorman mdorman deleted the perlcriticrc branch January 11, 2016 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants