New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write go test output to temporary file #887

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mpolden
Contributor

mpolden commented Feb 27, 2016

This avoids littering a project with .test executables..

The -o flag was added in Go 1.4 (golang/go@ce143f2).

I decided to keep using temporary-file-name, similar to the go-build check, as #838 hasn't been resolved yet.

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Feb 27, 2016

Thanks a lot for this contribution! I haven't followed the Go discussion closely, but this looks reasonable to me :) I'll let @lunaryorn give a final opinion.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Feb 27, 2016

@cpitclaudel I'm not familiar with Go at all. It's a good change in and by itself, so if it passes the Go tests, please feel free to apply this change to master ☺️

@lunaryorn lunaryorn added S-ready and removed B-needs review labels Feb 27, 2016

@lunaryorn lunaryorn added this to the Flycheck 1.0 milestone Feb 27, 2016

@mpolden

This comment has been minimized.

Contributor

mpolden commented Feb 28, 2016

Anything else needed here? I tested the change and it seems to work.

@lunaryorn lunaryorn closed this in 5c0ee54 Feb 28, 2016

@lunaryorn lunaryorn removed the S-ready label Feb 28, 2016

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Feb 28, 2016

@martinp Great. I've applied your change to master. Thank you very much.

@mpolden

This comment has been minimized.

Contributor

mpolden commented Feb 28, 2016

@lunaryorn Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment