Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Go unconvert checker #905
Yes, it needs a saved buffer, much like errcheck does. I've checked, and errcheck has roughly the same performance characteristics:
So if we're fine with running errcheck, we're probably also fine with running unconvert(?)
@dominikh I've finally merged this one. Sorry for the delay, and many thanks for the contribution.
Would you like to join our team to look after and take care of Flycheck's Go support? We'd give you commit access so that you can merge Go-related pull requests yourself and directly commit fixes to the Go support to
@dominikh Thank you for understanding.
I've sent you an invitation for our org. Once accepting it you should get commit access to our repository.
There's also a guide for maintainers but it's still very much in progress. But I'll try to add guidelines for reviewing and merging PRs soon.
Generally we do everything per pull request, except for smaller fixes (e.g. typos, obvious bugs, etc.). When merging PRs we tend to cherry pick commits when the pull request is small—like this one—and only do proper merges when there's a really large feature with many commits coming in, where we should preserve the history of the feature and provide single point to revert the entire change in case of breakage.
If you're using Magit take a look at magit-gh-pulls which adds pull requests to Magit's status buffer and let's you fetch the corresponding commits into the local clone. It's my main interface to review pull requests–by looking at the commits and/or checking them out and testing the change–and to merge pull requests—I simply apply commits from a pull request to master, squash them, and amend them if necessary (mostly for doc improvements, and adding issue references to the commit message). Credit for this workflow goes to @syl20bnr who uses it for Spacemacs and told me about it.
I hope to get all of this information with more detailled instructions into the maintainer guide soon, but meanwhile that's it; we're not really doing a lot of magic here
Please ask if you have any further questions, and welcome on board!
added a commit
this pull request
Apr 29, 2016
Okay, the workflow sounds largely similar to mine (except for more CLI magic and less magit), so that's great. I assume that contributors need peer review on their PRs before merging them as well, assuming the change justifies a PR?