New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up go-errcheck checker #906

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dominikh
Member

dominikh commented Mar 12, 2016

errcheck has a new flag and fixed a bug that makes the checker implementation a lot simpler. The bug was fixed late February 2015, the flag was added late August 2015.

/cc @lunaryorn

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Mar 14, 2016

@dominikh Thank you very much, great change for the better! Just would you mind to document the minimum version requirement for go errcheck (i.e. the first version that has this flag) in the syntax checker docstring?

@dominikh

This comment has been minimized.

Member

dominikh commented Mar 14, 2016

Does a git commit sha constitute a version? errcheck doesn't have explicit releases/version numbers.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Mar 14, 2016

@dominikh Uuuh 😒 in this case, please include an abbreviated commit hash and the date when the change was pushed.

dominikh added some commits Mar 12, 2016

go-errcheck: use -abspath flag
The -abspath flag was introduced in commit
8515d34a8746fc0ab1c652594faaeed138694c49 on the 25th of August, 2015. It
causes errcheck to print absolute file paths.

This change simplifies the code and makes it work correctly with
multiple GOPATH entries (see issue #580.)
go-errcheck: don't require a package name
Commit 7aedea6 switched from running
errcheck on "." to running it on an import path, to work around
kisielk/errcheck#45. That issue has since been
fixed. Running on "." has been working again since the 27th of February 2015.
Delete flycheck-go-package-name
It was only required by the go-errcheck checker, which doesn't need it
anymore. It's unlikely that other checkers in the future will need it,
and if they do, the function can be extracted from the git history.

@dominikh dominikh force-pushed the dominikh:go-errcheck-cleanup branch from 4a9cda6 to 2a30de0 Mar 14, 2016

@dominikh

This comment has been minimized.

Member

dominikh commented Mar 14, 2016

@lunaryorn PTAL.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Mar 17, 2016

@dominikh Thank you very much, cherry-picked ☺️ 👍

lunaryorn added a commit that referenced this pull request Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment