Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether R has installed the library lintr #911

Closed
wants to merge 1 commit into from
Closed

Check whether R has installed the library lintr #911

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 18, 2016

No description provided.

:message (if has-lintr "present" "missing")
:face (if has-lintr 'success '(bold error)))))))

(defun flycheck-R-has-lintr (R)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a lowercase r. I know that the language name is R, but for the sake of consistency I'd like to stick to Emacs Lisp' naming conventions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please move this function before the syntax checker definition :)

@swsnr
Copy link
Contributor

swsnr commented Mar 18, 2016

@marsam Nice, thank you very much 👍 There are a couple of minor issues which I'd like to ask you ti fix, but other than that it looks good, in my opinion ☺️

@marsam
Copy link
Contributor Author

marsam commented Mar 19, 2016

Hi, I've updated the pull request, tell me if there is more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants