Use each_with_object instead of each here

flyerhzm · Jun 9, 2012 · f9cfe9a · f9cfe9a
1 parent aa2bfd6
commit f9cfe9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/activerecord/lib/active_record/attribute_methods.rb b/activerecord/lib/active_record/attribute_methods.rb
@@ -149,9 +149,9 @@ def attribute_names
 
     # Returns a hash of all the attributes with their names as keys and the values of the attributes as values.
     def attributes
-      attrs = {}
-      attribute_names.each { |name| attrs[name] = read_attribute(name) }
-      attrs
+      attribute_names.each_with_object({}) { |name, attrs|
+        attrs[name] = read_attribute(name)
+      }
     end
 
     # Returns an <tt>#inspect</tt>-like string for the value of the

diff --git a/activerecord/lib/active_record/relation/predicate_builder.rb b/activerecord/lib/active_record/relation/predicate_builder.rb
@@ -4,7 +4,7 @@ def self.build_from_hash(engine, attributes, default_table)
       attributes.map do |column, value|
         table = default_table
 
-        if value.is_a?(Hash)
+        if value.is_a?(Hash) && !value.empty?
           table = Arel::Table.new(column, engine)
           value.map { |k,v| build(table[k.to_sym], v) }
         else