Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jun 15, 2012
  1. @drogus

    Add ActionView::Base.default_formats

    drogus authored
    default_formats array is used by LookupContext in order to allow
    rendering templates when :formats option is not passed. Previously it
    was always set to Mime::SET, which created dependency on Action Pack. In
    order to remove this dependency, Mime::SET is used only if
    ActionController is loaded.
  2. @drogus

    Remove Mime::Type translations from Action View

    drogus authored
    Action View should not be responsible for translating mime types. Any
    formats that are passed to Action View classes should be in form of
    symbols, like :xml or :json. Any translation that's needed should be
    handled at controller level.
  3. @drogus

    Remove mime types lookup from auto_discovery_link_tag

    drogus authored
    Automatically handling mime types for things other than :rss and :atom
    is not functionality that justifies dependency on Mime::Type from
  4. @drogus

    Do not add html format if user wants javascript

    drogus authored
    If a user wants javascript (ie. Accept: text/javascript) is sent, we
    should not try to return HTML. It may be confusing and, what's even
    more important, it's against HTTP spec.
Commits on Jun 14, 2012
  1. @drogus

    Remove comment about getting rid of old behavior

    drogus authored
    I've talked to José Valim, who added this comment, and there is no need
    to remove old API. It's good to have a simple way to instantiate
    ActionView::Base, by just passing view paths as a first argument,
    instead of constructing LookupContext and then the Renderer.
    [ci skip]
  2. @drogus

    Remove stubs from LogSubscriber tests

    drogus authored
    We can use another way to instantiate ActionView::Base, by passing
    renderer as a first option. Thanks to that we can just pass prefixes to
    LookupContext instead stubbing them on the controller. This is also good,
    because that kind of API is used in Rails code.
Commits on Jun 10, 2012
  1. @drogus

    Fix railties tests

    drogus authored
    Action View was moved out of Action Pack, so locales are now located
    inside actionview gem.
Commits on Jun 9, 2012
  1. @drogus

    Move ActionView::TestCase to Action Pack

    drogus authored
    Although it's a file in ActionView namespace, it's valid only for
    testing views with ActionController involved. That's why it can't be
    used in Action View alone and needs to be moved to Action Pack.
  2. @drogus
  3. @drogus

    Add missing include in actionview/test/abstract_unit.rb

    drogus authored
    This needs to be insterted here to make code added in 60b4290 work. It's
    not added here due to extraction of actionview into separate gem.
  4. @drogus
  5. @drogus

    Move action_controller/vendor/html-scanner to action_view

    drogus authored
    This is another step in moving Action View's dependencies in Action Pack
    to Action View itself. Also, HtmlScanner seems to be better suited for
    views rather than controllers.
  6. @drogus

    Move ActionController::RecordIdentifier to ActionView

    drogus authored
    Since it's more about DOM classes and ids it belongs to Action View
    better. What's more, it's more convenient to make it part of Action View
    to follow the rule that Action Pack can depend on Action View, but not
    the other way round.
  7. @drogus

    Remove dependency on actionpack in ActionView::AssetPaths

    drogus authored
    Since Action View should not depend on actionpack, it's best to delegate
    invalid_asset_host! to controller and just rely on such simple contract
    instead of raising this exception directly.
  8. @drogus

    Remove unneeded files

    drogus authored
  9. @drogus

    Moved template tests from actionpack to actionview

    drogus authored
    I ensured that all the tests in actionpack still pass, but tests in
    actionview fail. The reason for leaving them that way is that I don't
    want to move files *and* change them at the same time as it will be
    much harder to track changes that way using git log.
  10. @drogus
  11. @drogus

    Add bare actionview gem to the root directory

    drogus authored
    This commit creates structure for Action View gem and is first of a
    series of commits extracting Action View from Action Pack. I don't want
    to do it in one large commit to allow easier track of changes later on.
  12. @spastorino
  13. @spastorino
  14. @josevalim

    Merge pull request #6687 from tiegz/3-2-optimizations

    josevalim authored josevalim committed
    ActiveRecord#attributes optimization: minimize objects created
  15. @drogus

    Fix tests, active_authorizer shouldn't include blank values

    drogus authored
    Fix for a test failing after: 00ff0a6
Commits on Jun 8, 2012
  1. @drogus

    Merge pull request #6668 from pomnikita/master

    drogus authored
    Compact array of values added to PermissionSet instance
  2. @rafaelfranca
  3. @drogus
  4. @arunagw

    We should not include engine.rake file into rake

    arunagw authored
    if we are passing -T which is skip_test_unit
    See issue #6673 for more details.
    I saw that we are not creating dummy app even if
    we do skip_test_unit.
    Fixes #6673
  5. @arunagw
Commits on Jun 7, 2012
  1. @rafaelfranca

    Merge pull request #6667 from yahonda/skip_polymorphic_index_with_oracle

    rafaelfranca authored
    Skip two tests with polymorphic if current adapter is Oracle Adapter.
  2. @rafaelfranca

    Merge pull request #6597 from frodsan/am_include_root_to_false

    rafaelfranca authored
    change AMS::JSON.include_root_in_json default value to false
  3. @yahonda

    Skip two tests with polymorphic if current adapter is Oracle Adapter.

    yahonda authored
    because Oracle Adapter does not support foreign keys if :polymorphic => true is used.
  4. @pomnikita
Commits on Jun 6, 2012
  1. @carlosantoniodasilva

    Merge pull request #6629 from marcandre/destroy

    carlosantoniodasilva authored
    Add ActiveRecord::Base#destroy!
  2. @marcandre
  3. @carlosantoniodasilva

    Merge pull request #6645 from amatsuda/reduce_string_instance

    carlosantoniodasilva authored
    Reduce number of String instance
  4. @amatsuda

    reduce number of Strings

    amatsuda authored
Something went wrong with that request. Please try again.