Permalink
Commits on Jun 15, 2012
  1. Add ActionView::Base.default_formats

    default_formats array is used by LookupContext in order to allow
    rendering templates when :formats option is not passed. Previously it
    was always set to Mime::SET, which created dependency on Action Pack. In
    order to remove this dependency, Mime::SET is used only if
    ActionController is loaded.
    drogus committed Jun 15, 2012
  2. Remove Mime::Type translations from Action View

    Action View should not be responsible for translating mime types. Any
    formats that are passed to Action View classes should be in form of
    symbols, like :xml or :json. Any translation that's needed should be
    handled at controller level.
    drogus committed Jun 15, 2012
  3. Remove mime types lookup from auto_discovery_link_tag

    Automatically handling mime types for things other than :rss and :atom
    is not functionality that justifies dependency on Mime::Type from
    actionpack.
    drogus committed Jun 15, 2012
  4. Do not add html format if user wants javascript

    If a user wants javascript (ie. Accept: text/javascript) is sent, we
    should not try to return HTML. It may be confusing and, what's even
    more important, it's against HTTP spec.
    drogus committed Jun 14, 2012
Commits on Jun 14, 2012
  1. Remove comment about getting rid of old AV::Base.new behavior

    I've talked to José Valim, who added this comment, and there is no need
    to remove old API. It's good to have a simple way to instantiate
    ActionView::Base, by just passing view paths as a first argument,
    instead of constructing LookupContext and then the Renderer.
    
    [ci skip]
    drogus committed Jun 14, 2012
  2. Remove stubs from LogSubscriber tests

    We can use another way to instantiate ActionView::Base, by passing
    renderer as a first option. Thanks to that we can just pass prefixes to
    LookupContext instead stubbing them on the controller. This is also good,
    because that kind of API is used in Rails code.
    drogus committed Jun 14, 2012
Commits on Jun 10, 2012
  1. Fix railties tests

    Action View was moved out of Action Pack, so locales are now located
    inside actionview gem.
    drogus committed Jun 10, 2012
Commits on Jun 9, 2012
  1. Move ActionView::TestCase to Action Pack

    Although it's a file in ActionView namespace, it's valid only for
    testing views with ActionController involved. That's why it can't be
    used in Action View alone and needs to be moved to Action Pack.
    drogus committed Jun 9, 2012
  2. Add missing include in actionview/test/abstract_unit.rb

    This needs to be insterted here to make code added in 60b4290 work. It's
    not added here due to extraction of actionview into separate gem.
    drogus committed Jun 9, 2012
  3. Move action_controller/vendor/html-scanner to action_view

    This is another step in moving Action View's dependencies in Action Pack
    to Action View itself. Also, HtmlScanner seems to be better suited for
    views rather than controllers.
    drogus committed Jun 9, 2012
  4. Move ActionController::RecordIdentifier to ActionView

    Since it's more about DOM classes and ids it belongs to Action View
    better. What's more, it's more convenient to make it part of Action View
    to follow the rule that Action Pack can depend on Action View, but not
    the other way round.
    drogus committed Jun 9, 2012
  5. Remove dependency on actionpack in ActionView::AssetPaths

    Since Action View should not depend on actionpack, it's best to delegate
    invalid_asset_host! to controller and just rely on such simple contract
    instead of raising this exception directly.
    drogus committed Jun 9, 2012
  6. Remove unneeded files

    drogus committed Jun 9, 2012
  7. Moved template tests from actionpack to actionview

    I ensured that all the tests in actionpack still pass, but tests in
    actionview fail. The reason for leaving them that way is that I don't
    want to move files *and* change them at the same time as it will be
    much harder to track changes that way using git log.
    drogus committed Jun 1, 2012
  8. Add bare actionview gem to the root directory

    This commit creates structure for Action View gem and is first of a
    series of commits extracting Action View from Action Pack. I don't want
    to do it in one large commit to allow easier track of changes later on.
    drogus committed May 31, 2012
  9. Merge pull request #6687 from tiegz/3-2-optimizations

    ActiveRecord#attributes optimization: minimize objects created
    josevalim committed with josevalim Jun 9, 2012
  10. Fix tests, active_authorizer shouldn't include blank values

    Fix for a test failing after: 00ff0a6
    drogus committed Jun 9, 2012
Commits on Jun 8, 2012
  1. Merge pull request #6668 from pomnikita/master

    Compact array of values added to PermissionSet instance
    drogus committed Jun 8, 2012
  2. Merge pull request #6681 from arunagw/plugin_gen_fix

    Plugin gen fix
    rafaelfranca committed Jun 8, 2012
  3. We should not include engine.rake file into rake

    if we are passing -T which is skip_test_unit
    
    See issue #6673 for more details.
    
    I saw that we are not creating dummy app even if
    we do skip_test_unit.
    
    Fixes #6673
    arunagw committed Jun 8, 2012
Commits on Jun 7, 2012
  1. Merge pull request #6667 from yahonda/skip_polymorphic_index_with_oracle

    Skip two tests with polymorphic if current adapter is Oracle Adapter.
    rafaelfranca committed Jun 7, 2012
  2. Merge pull request #6597 from frodsan/am_include_root_to_false

    change AMS::JSON.include_root_in_json default value to false
    rafaelfranca committed Jun 7, 2012
  3. Skip two tests with polymorphic if current adapter is Oracle Adapter.

    because Oracle Adapter does not support foreign keys if :polymorphic => true is used.
    yahonda committed Jun 7, 2012
Commits on Jun 6, 2012
  1. Merge pull request #6629 from marcandre/destroy

    Add ActiveRecord::Base#destroy!
    carlosantoniodasilva committed Jun 6, 2012
  2. Merge pull request #6645 from amatsuda/reduce_string_instance

    Reduce number of String instance
    carlosantoniodasilva committed Jun 6, 2012
  3. reduce number of Strings

    amatsuda committed Jun 4, 2012