New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exclude option #18

Merged
1 commit merged into from Oct 8, 2010

Conversation

Projects
None yet
2 participants
@recurser
Contributor

recurser commented Oct 8, 2010

Hi flyerhzm, rails_best_practices is dying on me because I have a haml generator installed (http://github.com/psynix/rails3_haml_scaffold_generator) :
(haml):10: Illegal nesting: nesting within plain text is illegal. (Haml::SyntaxError)
from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:354:in push_plain' from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:278:inprocess_line'
from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:178:in precompile' from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/engine.rb:121:ininitialize'
from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:33:in new' from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:33:incheck'
from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:46:in check_file' from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38 from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38:ineach'
from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38
from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:inrequire'
from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/bin/rails_best_practices:6
from /usr/local/bin/rails_best_practices:19:in `load'
from /usr/local/bin/rails_best_practices:19

I managed to track the problem down to two views in the generator, but in the end decided it would be easier just to be able to exclude stuff that I don't care about from rails_best_practices. The command.rb stuff is based on the rcov exclude option code.

@flyerhzm

This comment has been minimized.

Owner

flyerhzm commented Oct 8, 2010

good job

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment