Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi flyerhzm, rails_best_practices is dying on me because I have a haml generator installed (http://github.com/psynix/rails3_haml_scaffold_generator) :
(haml):10: Illegal nesting: nesting within plain text is illegal. (Haml::SyntaxError)
from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:354:in
push_plain' from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:278:in
process_line'from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/precompiler.rb:178:in
precompile' from /usr/local/Cellar/gems/1.8/gems/haml-3.0.21/lib/haml/engine.rb:121:in
initialize'from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:33:in
new' from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:33:in
check'from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/core/runner.rb:46:in
check_file' from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38 from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38:in
each'from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/lib/rails_best_practices/command.rb:38
from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in
gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in
require'from /usr/local/Cellar/gems/1.8/gems/rails_best_practices-0.4.4/bin/rails_best_practices:6
from /usr/local/bin/rails_best_practices:19:in `load'
from /usr/local/bin/rails_best_practices:19
I managed to track the problem down to two views in the generator, but in the end decided it would be easier just to be able to exclude stuff that I don't care about from rails_best_practices. The command.rb stuff is based on the rcov exclude option code.