Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the javascript redirect respect the relative_url_root #95

Merged
merged 2 commits into from Jul 24, 2016

Conversation

Projects
None yet
2 participants
@westonganger
Copy link
Contributor

commented Jul 22, 2016

If you have an application thats deployed to a sub-directory then the javascript redirect onchange of the select element would point to the wrong url. This fixes this.

@flyerhzm

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2016

@westonganger could you fix all root url, like checkbox code above the select box, thanks.

btw, could you rebase the master branch which has all tests passed.

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2016

Sure. I have fixed the checkbox and rebased.

@flyerhzm flyerhzm merged commit 17e8fc3 into flyerhzm:master Jul 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.