New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed::Job delete_all does not accept arguments in delayed_job (4.1.5) #19

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@thebravoman

thebravoman commented Apr 23, 2018

There is a call in the index_sql to Delayed::Job. The call deletes all the jobs. But as of delayed_job 4.1.5 there is no argument to the delete_all method. Not sure if there was an argument before.

@pat

This comment has been minimized.

Member

pat commented Apr 23, 2018

Thanks for figuring out the source of the bug and supplying a patch! I think what you've supplied is spot on - the old approach would have worked with Rails pre-3.0, but given FS 2.x relies on TS 4.x, which in turn relies on Rails 3.2+, your change should work everywhere it has to 👍

@pat

This comment has been minimized.

Member

pat commented Apr 23, 2018

I've just cherry-picked this into the develop branch as e1a1af4 (hence closing this PR), which will get merged into master with the next gem release (I'm aiming for the start of next week).

@pat pat closed this Apr 23, 2018

@pat

This comment has been minimized.

Member

pat commented Apr 30, 2018

Just published v2.1.1 which includes this fix :)

@thebravoman

This comment has been minimized.

thebravoman commented Apr 30, 2018

Confirmed with v.2.1.1. Just migrated and ts:index is working.

@rogerkk

This comment has been minimized.

rogerkk commented May 23, 2018

Thanks for this fix, @thebravoman! ❤️ Just stumbled upon the same bug and v2.1.1 saved the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment