Paper/computational holography #5
Conversation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughManuscript and build automation updates: dynamic Makefile TEX_SRCS, LaTeX source reorganization and notation standardization (U ↔ 𝒰, hyphenation changes), new Echo determinism subsection and unfoldings, bibliography edits (add Arrighi2025, remove RossAIONCalculus2025), title/metadata tweaks, and a GitHub Actions workflow to publish the PDF. Changes
Sequence Diagram(s)Build sequence invoked by Makefile (high-level) sequenceDiagram
autonumber
participant Dev as Developer / CI
participant Make as Makefile
participant LaTeX as pdflatex
participant Bib as bibtex
Note over Make,LaTeX: Prereqs include $(MAIN).tex + $(TEX_SRCS) + references.bib
Dev->>Make: make (target: $(MAIN).pdf)
Make->>LaTeX: pdflatex (1st pass)
LaTeX-->>Make: .aux/.toc produced
Make->>Bib: bibtex
Bib-->>Make: .bbl produced
Make->>LaTeX: pdflatex (2nd pass)
Make->>LaTeX: pdflatex (3rd pass)
LaTeX-->>Dev: $(MAIN).pdf
GitHub Actions release flow (high-level) sequenceDiagram
autonumber
participant Git as GitHub (tag push)
participant Actions as workflow
participant Builder as latex-action
participant FS as runner filesystem
participant Release as GH Release
Git->>Actions: push tag v*-paper
Actions->>Builder: checkout + build main.tex
Builder-->>FS: produce aion-holography/main.pdf
Actions->>Release: create release, attach PDF
Release-->>Git: published release with PDF asset
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Areas needing extra attention:
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
aion-holography/intro.tex (2)
18-23: Invariant wording and theorem cross-refs look correct; minor style nit onlyThe “no-delete/no-clone-under-descent invariants” phrasing and the references to
\cref{thm:tick-confluence,thm:two-plane,thm:global}line up with the rest of the document and the assumptions table.If you want to be hyper-consistent:
- You use “typed open graphs” earlier, but here you say “typed open-graph isomorphism”. Consider either “typed open graph isomorphism” or “typed open-graph isomorphism” consistently across the paper; right now it’s a bit mixed.
This is purely stylistic; semantically the paragraph is fine.
Also applies to: 30-40
61-69: Clarify what “Worldline uniqueness” adds beyond tick-level confluenceThe new bullet:
\item \emph{Worldline uniqueness} (Corollary~\ref{cor:worldline-uniqueness}): every schedule of a given tick produces the same successor up to isomorphism;reads very close to the first bullet:
tick-level confluence … yielding deterministic semantics independent of scheduler serialization order.
Unless
\ref{cor:worldline-uniqueness}is making a genuinely stronger/global statement (e.g., uniqueness of entire derivation worldlines, not just a single tick), this risks sounding like a duplicate.I’d either:
- sharpen the corollary’s description to emphasize what’s strictly stronger (e.g. “global worldline uniqueness for complete runs”), or
- fold it into the first bullet as “plus Corollary~\ref{cor:worldline-uniqueness} (schedule-independent worldlines)”.
Right now the distinction is too subtle for a “Key contributions” list.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (13)
aion-holography/Makefile(1 hunks)aion-holography/assumptions.tex(1 hunks)aion-holography/determinism_confluence.tex(10 hunks)aion-holography/discussion.tex(3 hunks)aion-holography/dpo_rmg.tex(2 hunks)aion-holography/intro.tex(3 hunks)aion-holography/macros.tex(1 hunks)aion-holography/main.tex(4 hunks)aion-holography/multiway_ruliad.tex(1 hunks)aion-holography/references.bib(1 hunks)aion-holography/rmg.tex(4 hunks)aion-holography/rulial_distance.tex(6 hunks)aion-holography/titlepage.tex(2 hunks)
🔇 Additional comments (17)
aion-holography/references.bib (1)
51-59: Arrighi 2025 BibTeX entry is syntactically consistentThe new
@misc{Arrighi2025Reversible,...}entry is well-formed and matches the style of the other arXiv-style entries in this file (field names, ordering, and comma usage). No issues from a BibTeX/LaTeX perspective.aion-holography/Makefile (1)
12-18: The subdirectory dependency concern doesn't apply to this codebaseAfter verification, the original review comment's core concern is unfounded. There are no subdirectories with
.texfiles inaion-holography/. All 14.texfiles live in the repository root:
main.texuses\inputdirectives to include:macros,titlepage,assumptions,intro,rmg,dpo_rmg,determinism_confluence,holography,wormholes,rulial_distance,multiway_ruliad,ethics, anddiscussion.- All referenced files are in the root, captured correctly by
$(wildcard *.tex).The Makefile change from (presumably) hardcoded
sections/*.texto the wildcard approach is actually an improvement, not a regression. The only valid suggestion is using:=instead of=for clarity and minor performance, but this is optional.Likely an incorrect or invalid review comment.
aion-holography/dpo_rmg.tex (1)
50-59: Unable to verify review comment — repository not accessibleI was unable to verify this review comment because:
- The repository
flyingrobots/aioncould not be cloned in the sandbox environment- The repository is not publicly available on GitHub or other code-hosting sites accessible via web search
What the review recommends:
The comment suggests making explicit the distinction betweenU(a single RMG state) and\mathcal{U}(a universe of states), and recommends scanning for potentially conflicting uses. This is a reasonable suggestion for notation clarity in a mathematical document.What I cannot confirm:
- Whether
\mathcal{U}is actually used inconsistently- Whether the distinction is already documented elsewhere in the document
- Whether lines 50-59 and 74-81 actually exhibit the concern described
- The specific context and scope of notation usage across the
aion-holographydirectoryaion-holography/main.tex (3)
66-93: LGTM: Page anchor and numbering structure is correct.The hyperref page anchor management (false for front matter, true for main content) prevents duplicate page identifiers in the PDF. The transition from roman to arabic numbering is standard.
95-105: All section input files are present and accessible.Verification confirms all 11 required
.texfiles exist in theaion-holography/directory: assumptions.tex, intro.tex, rmg.tex, dpo_rmg.tex, determinism_confluence.tex, holography.tex, wormholes.tex, rulial_distance.tex, multiway_ruliad.tex, ethics.tex, and discussion.tex. The\input{}commands at lines 95-105 will resolve correctly with no compilation failure risk from missing files.
30-30: The 10.5pt font metric entry is intentional and correct—no action needed.The
<10.5> stmary10declaration is a legitimate font substitution rule within a\DeclareFontShapeblock. This is standard LaTeX practice: when the document requests 10.5pt, the declaration explicitly maps it to the stmary10 font. All sizes from 10pt onward in this font declaration map to stmary10, which is a deliberate consolidation since only discrete optical sizes exist for the stmary family. The intermediate 10.5pt entry fills the gap between<10>and<10.95>(the standard TeX size) and will not cause font substitution issues.aion-holography/rulial_distance.tex (3)
127-153: LGTM: Improved theorem title.The new title "Main theorem on rulial distance (triangle inequality)" better emphasizes the result's significance while clarifying its mathematical content. The explicit callout to
\cref{thm:rulial-basic}at line 150 correctly uses the updated label.
110-114: All cross-references have been properly updated.The verification confirms that the label change from
lem:rulial-basictothm:rulial-basicis complete:
- No remaining old label references (zero matches for
lem:rulial-basic)- New label properly used in all three locations:
- Definition at line 110 in
rulial_distance.tex- Reference at line 150 in
rulial_distance.tex- Reference at line 23 in
assumptions.tex
11-21: Notation consistency verified across all aion-holography files.The universe notation change from
Uto\mathcal{U}is complete and consistent. No instances of the old notation ("universe U" or\Hist(U,) remain. All occurrences properly distinguish the universe (\mathcal{U}) from state elements (U ∈ \mathcal{U}), with correct usage verified in rmg.tex, rulial_distance.tex, and multiway_ruliad.tex.aion-holography/rmg.tex (2)
29-31: LGTM: Clarifying addition.The explicit connection to the set-theoretic and initial-algebra presentation helps readers understand the formal foundation.
177-196: LGTM: Universe notation updates are consistent.The notation change from
U(universe) to\mathcal{U}(universe) withU \in \mathcal{U}(state) is consistently applied. The explicit clarification at lines 190-192 helps readers distinguish between the universe and individual states.aion-holography/determinism_confluence.tex (4)
52-89: Excellent visual addition for footprint independence.The new figure clearly illustrates the overlapping match scenario and the Del/Use distinction. The caption correctly explains the independence criterion. The TikZ code is clean and well-structured.
137-140: LGTM: Appropriate citation of related work.The reference to Arrighi2025Reversible correctly positions it as parallel work using similar categorical techniques. The phrasing "similar categorical techniques appear in the space--time reversible graph-rewriting setting" is accurate and appropriately modest.
10-17: LGTM: Explicit state notation improves clarity.The expanded notation
U = (G;\alpha,\beta)makes the RMG state structure explicit at first use, improving readability. The cross-reference updates using\cref{def:rmg-state,def:rmg-tick}are correct.
224-253: I encountered a repository access issue that prevents me from executing the verification script. However, based on the provided review comment and the code snippet shown (lines 224-253), I can see that the definition is properly using the hyphenated form "no-delete/no-clone-under-descent."Since I cannot access the full repository to verify consistency across all files in the aion-holography directory, I'll provide a rewritten review comment that reflects this limitation:
Verify consistent hyphenation of "no-delete/no-clone-under-descent" throughout the document.
The hyphenation change from "no-delete/no-clone under descent" to "no-delete/no-clone-under-descent" is grammatically correct for a compound adjective and is properly applied in the definition at lines 224-253. Ensure this terminology is used consistently across all references in related files within the aion-holography directory. Check for any remaining instances of the unhyphenated variant "no-delete/no-clone under descent" that may need updating.
aion-holography/discussion.tex (2)
82-85: "Time Cone" terminology is consistent throughout the document. Verification complete — no remaining "Time Cube" references found.The change from "Time Cube" to "Time Cone" has been successfully applied. "Time Cone" appears consistently in:
discussion.texline 82 (the section under review)multiway_ruliad.texlines 97 and 99 (where the concept is expanded)No lingering "Time Cube" terminology remains in the codebase, confirming the update is complete and uniform.
25-32: Citation Arrighi2025Reversible exists and is properly formatted, but the characterization needs clarification.The BibTeX entry is present with correct authors (Arrighi, Costes, Maignan) and year (2025):
@misc{Arrighi2025Reversible, author = {Arrighi, Pablo and Costes, Marin and Maignan, Luidnel}, title = {Space-time Reversible Graph Rewriting}, year = {2025}, eprint = {2510.03296}, archivePrefix = {arXiv}, primaryClass = {cs.DM}, url = {https://arxiv.org/abs/2510.03296} }However, the paper's actual title is "Space-time Reversible Graph Rewriting," not "space--time deterministic and reversible graph dynamics" as characterized in discussion.tex. Verify that the description in lines 25-32 accurately reflects the paper's content, particularly regarding whether it addresses "deterministic and reversible graph dynamics" or focuses on graph rewriting methodology.
…ots/aion into paper/computational-holography
There was a problem hiding this comment.
Actionable comments posted: 10
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
aion-holography/determinism_confluence.tex (1)
224-253: Define or cross‑reference “skeleton ancestor” and be explicit about “obtained from”.Lines 239–242: ND uses “skeleton ancestor”:
“no object in any attachment graph has
$x$ as its skeleton ancestor.”That’s not standard terminology, and this section currently doesn’t define it. Either:
- give a quick local definition (e.g. via the tree-of-graphs picture from the RMG section), or
- explicitly cross‑reference where “skeleton ancestor” was introduced.
Similarly, Line 245–248 (NC) says an attachment over
$x'$ is “obtained from” the attachment over$x$ via attachment–plane DPOI steps. For pedantic clarity, you probably want to say “is (up to isomorphism) obtained … solely by the attachment–plane DPOI steps in the same tick”, so it’s clear you’re talking about the constructed morphism class, not literal identity-on-the-nose.These are small wording fixes but matter for readers trying to mechanically reconstruct the semantics from this definition.
♻️ Duplicate comments (4)
aion-holography/titlepage.tex (2)
29-30: LGTM! ORCID link properly implemented.The ORCID is now a clickable
\hreflink with a clear label, addressing the previous review feedback.
45-48: LGTM! License text is now unambiguous.The full Creative Commons Attribution 4.0 International name and canonical URL are now specified, removing any ambiguity about which CC BY variant is intended.
aion-holography/assumptions.tex (1)
13-22: LGTM! Cross-reference style is now consistent.All rows in the assumptions table now use
\cref{...}consistently, addressing the previous review feedback about mixed\refand\crefstyles.aion-holography/macros.tex (1)
24-29: Macro documentation addresses staleness concerns.The
\PaperVersionmacro and the comments on lines 25-27 explaining how to override\PaperDatefor archival builds address the previous review feedback. The\providecommandpattern allows external overrides while maintaining sensible defaults.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (10)
-
.github/workflows/release-paper.yml(1 hunks) -
aion-holography/assumptions.tex(1 hunks) -
aion-holography/determinism_confluence.tex(10 hunks) -
aion-holography/discussion.tex(3 hunks) -
aion-holography/intro.tex(3 hunks) -
aion-holography/macros.tex(1 hunks) -
aion-holography/main.tex(4 hunks) -
aion-holography/multiway_ruliad.tex(1 hunks) -
aion-holography/rmg.tex(4 hunks) -
aion-holography/titlepage.tex(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-holography
🔇 Additional comments (9)
aion-holography/multiway_ruliad.tex (1)
89-110: LGTM! Previous review concerns addressed.The updated content properly uses TeX quotes (``light-cone''), includes the forward reference via
\cref{subsec:chronos-kairos-aion}, and adds spacing in the `\Hist` arguments. The three-layer time model subsection is cleanly structured.aion-holography/discussion.tex (3)
12-36: Solid implementation guarantees subsection.The seven determinism invariants are clearly articulated with precise semantics. The explicit tie to bit-level reproducibility and test suite coverage grounds the theoretical claims in concrete guarantees.
One consideration: the past review suggested this might belong in a separate "Implementation" section rather than "Discussion and Future Work." The current placement is acceptable since it's clearly labeled as a subsection, but if this section grows, consider promoting it.
51-58: Related work citation is well-integrated.The Arrighi–Costes–Maignan paragraph clearly distinguishes your work's focus (deterministic multiway semantics and holographic provenance) from their physical geometry orientation while acknowledging the shared categorical machinery.
108-111: Time Cone terminology consistent with multiway_ruliad.tex.The Chronos/Kairos/Aion triad is correctly referenced here, maintaining terminological consistency with the definitions in Section~\ref{sec:multiway}.
aion-holography/intro.tex (2)
18-22: Terminology alignment verified.The "no-delete/no-clone-under-descent" phrasing matches the assumptions table and other sections. The theorem cross-references (
thm:tick-confluence,thm:two-plane,thm:global) provide clear entry points for readers.
61-71: Key contributions clearly delineated.The distinction between tick-level confluence and worldline uniqueness is sharp: the former guarantees per-tick determinism, the latter extends this to complete executions. The phrasing "regardless of scheduler order" hammers the point home.
aion-holography/main.tex (2)
66-67: Good use ofpageanchor=falsefor front matter.Disabling page anchors before the title page and re-enabling after the TOC (line 92) prevents hyperref from creating conflicting anchors when page numbering resets from roman to arabic. This is the correct pattern.
30-30: Font shape declaration for 10.5pt is reasonable.Mapping
<10.5>tostmary10follows the established pattern in this block. Since stmary doesn't have a dedicated 10.5pt design size, scaling from the 10pt is standard practice.aion-holography/rmg.tex (1)
179-187: Notation split between state$U$ and universe$\mathcal{U}$ now looks coherent.
- Line 179 row:
$U = (G;\alpha,\beta)$as a single RMG state in universe$\mathcal{U}$ .- Lines 192–194: “an RMG universe
$\mathcal{U}$ is a set of RMG states … and$U \in \mathcal{U}$ denotes a particular state in that universe.”- Lines 197–198:
$\Hist(\mathcal{U},R)$as the history category on the universe$\mathcal{U}$ of RMG states.This fixes the earlier overload of calligraphic
$\mathcal{U}$ and aligns with the updated notation indeterminism_confluence.tex. No further changes needed here.Also applies to: 192-194, 197-198
No description provided.