-
Notifications
You must be signed in to change notification settings - Fork 0
Add arXiv packaging helper script #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughAdds a new Bash script Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer / CI
participant Script as make-arxiv.sh
participant LaTeX as latexmk
participant Rsync as rsync
participant Sed as sed
participant Tar as tar
Note over Script: start (set -euo pipefail + trap)
Dev->>Script: run script
Script->>LaTeX: run latexmk(main.tex)
alt latexmk success
LaTeX-->>Script: main.bbl updated
Script->>Rsync: rsync Makefile, *.tex, main.bbl -> tmpdir
Rsync-->>Script: files copied
Script->>Sed: strip full-line comments from *.tex in tmpdir
Sed-->>Script: cleaned files
Script->>Tar: create ax.tar from tmpdir
Tar-->>Script: ax.tar created
Script-->>Dev: output path to ax.tar (success)
else latexmk failure
LaTeX-->>Script: error
Script-->>Dev: exit with error (cleanup)
end
Note over Script: cleanup tmpdir (trap)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Potential focus areas:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
aion-holography/scripts/make-arxiv.sh(1 hunks)
🔇 Additional comments (1)
aion-holography/scripts/make-arxiv.sh (1)
1-43: Overall script structure is sound, but error propagation is fragile.The script properly uses
set -euo pipefailand trap-based cleanup, which is excellent practice. However, the subshell in the comment-stripping loop undermines the error-handling guarantees. The fixes above (especially the process substitution refactor) will resolve the critical issue and ensure consistent behavior across the script.Please verify that:
- The directory structure assumptions (script at
aion-holography/scripts/make-arxiv.sh) match your repository layout.- Nested .tex files (if any exist in subdirectories) should be comment-stripped and included in the arXiv tarball.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: James Ross <james@flyingrobots.dev>
No description provided.