Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: Attempt libvirt commands multiple times #1458

Merged
merged 1 commit into from Apr 16, 2015

Conversation

Projects
None yet
2 participants
@lmars
Copy link
Member

lmars commented Apr 15, 2015

Fixes #1451.

I tried to run strace on the libvirt daemon to see why it is restarting, but then I could not reproduce the error, I guess Heisenberg's uncertainty principle applies :trollface:.

Given we will be moving away from libvirt soon, I have opted to just keep retrying the domain creation for upto 10 seconds, which should hide the fact that it is temporarily unavailable for some unknown reason.

@lmars

This comment has been minimized.

Copy link
Member Author

lmars commented Apr 15, 2015

Ok this didn't work, the underlying connection continues to fail, we need to create a new connection instead, will fix.

host: Attempt libvirt commands multiple times
In case the libvirt daemon is temporarily unavailable (e.g. because it
has restarted, which sometimes happens in CI).

Signed-off-by: Lewis Marshall <lewis@lmars.net>

@lmars lmars force-pushed the libvirt-retries branch from a799eb1 to f75c357 Apr 16, 2015

@lmars

This comment has been minimized.

Copy link
Member Author

lmars commented Apr 16, 2015

Updated to create a new libvirt connection if necessary, please review.

@titanous

This comment has been minimized.

Copy link
Member

titanous commented Apr 16, 2015

LGTM

lmars added a commit that referenced this pull request Apr 16, 2015

Merge pull request #1458 from flynn/libvirt-retries
host: Attempt libvirt commands multiple times

@lmars lmars merged commit 02fde43 into master Apr 16, 2015

1 check passed

continuous-integration/flynn The Flynn CI build passed
Details

@lmars lmars deleted the libvirt-retries branch Apr 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.