Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add limit command for managing resource limits #1553

Merged
merged 2 commits into from May 20, 2015

Conversation

Projects
None yet
3 participants
@lmars
Copy link
Member

commented May 19, 2015

No description provided.

$ flynn limit
web: max_fd=12000 max_procs=1024 memory=256MB
worker: max_fd=10000 max_procs=256 memory=1GB

This comment has been minimized.

Copy link
@titanous

titanous May 19, 2015

Member

We need to drop max_procs, as it doesn't work (and won't until we sort some uid management stuff out)

lmars added some commits May 19, 2015

cli: Add limit command for managing resource limits
Signed-off-by: Lewis Marshall <lewis@lmars.net>
controller: Assign default limits to one-off jobs
Signed-off-by: Lewis Marshall <lewis@lmars.net>

@lmars lmars force-pushed the cli-limits branch from 64ad1a0 to da31ec6 May 20, 2015

@lmars

This comment has been minimized.

Copy link
Member Author

commented May 20, 2015

@titanous comments addressed, as well as assigning default limits to one-off jobs.

func byteSize(limit int64) string {
i := 0
unit := 1024.0
size := float64(limit)

This comment has been minimized.

Copy link
@titanous

titanous May 20, 2015

Member

Why are we using floats?

This comment has been minimized.

Copy link
@lmars

lmars May 20, 2015

Author Member

So that a limit of say 1.5GB is reported as so (rather than 1GB)

This comment has been minimized.

Copy link
@titanous

titanous May 20, 2015

Member

Ah, got it.

@titanous

This comment has been minimized.

Copy link
Member

commented May 20, 2015

LGTM

lmars added a commit that referenced this pull request May 20, 2015

Merge pull request #1553 from flynn/cli-limits
cli: Add limit command for managing resource limits

@lmars lmars merged commit 0f4d359 into master May 20, 2015

1 check failed

continuous-integration/flynn The Flynn CI build failed
Details

@lmars lmars deleted the cli-limits branch May 20, 2015

}
}

var byteUnits = []string{"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"}

This comment has been minimized.

Copy link
@danielsiders

danielsiders May 20, 2015

Member

I'd like for us to add support for Novabytes (1000^9 / 10^27) and Dexabytes (1000^10 / 10^30) to help promote the new names I've devised and support higher limits on more powerful nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.