Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: Various updates #1756

Merged
merged 6 commits into from Aug 28, 2015

Conversation

Projects
None yet
2 participants
@lmars
Copy link
Member

commented Aug 26, 2015

Extracted from #1672

@lmars lmars force-pushed the host-updates branch from a7f242b to bd146a1 Aug 26, 2015

-d, --detached run job without connecting io streams (implies --enable-log)
-r <release> id of release to run (defaults to current app release)
-e <entrypoint> overwrite the default entrypoint of the release's image
-l, --enable-log send output to log streams

This comment has been minimized.

Copy link
@titanous

titanous Aug 26, 2015

Member

Is this flag necessary?

This comment has been minimized.

Copy link
@lmars

lmars Aug 26, 2015

Author Member

I added it in case I want to run a command in the terminal but also have the output go to the logs, e.g. flynn run --enable-log rake db:migrate

This comment has been minimized.

Copy link
@titanous

titanous Aug 26, 2015

Member

Gotcha.

service: service,
stop: make(chan struct{}),
done: make(chan struct{}),
inst: inst.Clone(),
}
h.c.Store(c)

This comment has been minimized.

Copy link
@titanous

titanous Aug 26, 2015

Member

Lets make a newHeartbeater method that does the setup.

@lmars lmars force-pushed the host-updates branch from bd146a1 to 4f28b2c Aug 26, 2015

@lmars

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2015

@titanous comments addressed

lmars added some commits Jul 28, 2015

host: Store container.Domain in libvirt backend job state
When restoring state, the libvirt backend watches the running
containers, which requires container.Domain.ID to be set.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
host: Close discoverd before stopping jobs
Signed-off-by: Lewis Marshall <lewis@lmars.net>
bootstrap: Add timeout to run_app_action
Signed-off-by: Lewis Marshall <lewis@lmars.net>
cli: Set DisableLog when running attached jobs
This avoids round-tripping via on-disk log files.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
host: Don't use a retry dialer for logmux discoverd client
logmux has its own reconnect logic, and using a retry dialer blocks
that logic unnecessarily.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
discoverd,host: Support updating a heartbeater's client
When the host switches from using a peer discoverd to a local one, it
currently unregisters the service before continuing to heartbeat via
the local client, which means down events are emitted for the service,
even though it is not down.

Signed-off-by: Lewis Marshall <lewis@lmars.net>

@lmars lmars force-pushed the host-updates branch from 4f28b2c to 2d69468 Aug 27, 2015

@titanous

This comment has been minimized.

Copy link
Member

commented Aug 28, 2015

LGTM

lmars added a commit that referenced this pull request Aug 28, 2015

@lmars lmars merged commit 4e61c1f into master Aug 28, 2015

1 check passed

continuous-integration/flynn The Flynn CI build passed
Details

@lmars lmars deleted the host-updates branch Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.