Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Fix github auth #1873

Merged
merged 2 commits into from Sep 15, 2015

Conversation

Projects
None yet
2 participants
@jvatic
Copy link
Member

commented Sep 15, 2015

@titanous

This comment has been minimized.

Copy link
Member

commented Sep 15, 2015

LGTM, but please add descriptions to the commit messages.

jvatic added some commits Sep 15, 2015

dashboard: Cleanup dead code
The App store had some dead code leftover from a refactor

Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
dashboard: Fix github auth
The github auth view was using a dead code path to save the token.

closes #1872

Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>

@jvatic jvatic force-pushed the dashboard-github-auth branch from b3c2401 to 7334e40 Sep 15, 2015

@jvatic

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2015

Added descriptions to the commit messages.

@titanous

This comment has been minimized.

Copy link
Member

commented Sep 15, 2015

🚢

jvatic added a commit that referenced this pull request Sep 15, 2015

@jvatic jvatic merged commit 33afb15 into master Sep 15, 2015

1 check was pending

continuous-integration/flynn The Flynn CI build is in progress
Details

@jvatic jvatic deleted the dashboard-github-auth branch Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.