Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrantfile: Avoid DNS rebind protection by using TEST-NET-1 #438

Merged
merged 1 commit into from Nov 13, 2014

Conversation

Projects
None yet
2 participants
@titanous
Copy link
Member

commented Nov 12, 2014

The TEST-NET subnets are specified in RFC 5737 for use in documentation, and should be fine for our host-only networking uses.

dnsmasq (used in many home/prosumer/smb routers) rebind protection uses this list which notably excludes all three TEST-NETs:

  • 127.0.0.0/8 (loopback)
  • 192.168.0.0/16 (private)
  • 10.0.0.0/8 (private)
  • 172.16.0.0/12 (private)
  • 169.254.0.0/16 (zeroconf)

I will update the DNS entries as soon as this is merged.

Vagrantfile: Avoid DNS rebind protection by using TEST-NET-1
The TEST-NET subnets are specified in RFC 5737 for use in
documentation, and should be fine for our host-only networking uses.

dnsmasq (used in many home/prosumer/smb routers) rebind protection
uses this list which notably excludes all three TEST-NETs:

- 127.0.0.0/8    (loopback)
- 192.168.0.0/16 (private)
- 10.0.0.0/8     (private)
- 172.16.0.0/12  (private)
- 169.254.0.0/16 (zeroconf)

Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
@lmars

This comment has been minimized.

Copy link
Member

commented Nov 13, 2014

LGTM. I always disliked the seemingly arbitrary subnet selections

titanous added a commit that referenced this pull request Nov 13, 2014

Merge pull request #438 from flynn/vagrant-testnet
Vagrantfile: Avoid DNS rebind protection by using TEST-NET-1

@titanous titanous merged commit e7b6894 into master Nov 13, 2014

1 of 2 checks passed

continuous-integration/travis-ci The Travis CI build is in progress
Details
flynn The Flynn CI build passed
Details

@titanous titanous deleted the vagrant-testnet branch Nov 13, 2014

@titanous

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2014

DNS updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.