Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Show deploy logs in UI + minor fixes #735

Merged
merged 4 commits into from Jan 15, 2015

Conversation

Projects
None yet
3 participants
@jvatic
Copy link
Member

commented Jan 14, 2015

screen shot 2015-01-14 at 3 50 52 pm

Note that only apps deployed through the dashboard with this version or later will have deploy logs visible in the dashboard UI.

@jvatic jvatic force-pushed the dashboard-deploy-logs branch 3 times, most recently from 9899bb8 to e214067 Jan 15, 2015

@titanous

This comment has been minimized.

Copy link
Member

commented Jan 15, 2015

I think we should show at least timestamps in the logs list. Is there any other identifying information that would make sense?

@lmars

This comment has been minimized.

Copy link
Member

commented Jan 15, 2015

I don't think the DOWN label makes sense, maybe Finished?

@jvatic

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2015

We can add any identifying information we want to the job meta (such as the git ref). I think timestamps definitely make sense (for both sets of logs).

Yeah, the DOWN label is a bit odd in the context of deploy logs.

jvatic added some commits Dec 30, 2014

dashboard: Fix nav selection
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
dashboard: Fix github deploy UI when postgres checkbox checked
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
dashboard: Don't show app source history if no github client
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
dashboard: Show deploy logs for apps
Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>

@jvatic jvatic force-pushed the dashboard-deploy-logs branch from f46e51e to e3cdd85 Jan 15, 2015

@jvatic

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2015

screen shot 2015-01-15 at 1 37 17 pm

@jvatic

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2015

@titanous, @lmars Comments addressed

@titanous

This comment has been minimized.

Copy link
Member

commented Jan 15, 2015

LGTM

jvatic added a commit that referenced this pull request Jan 15, 2015

Merge pull request #735 from flynn/dashboard-deploy-logs
dashboard: Show deploy logs in UI + minor fixes

@jvatic jvatic merged commit 24e4c1b into master Jan 15, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jvatic jvatic deleted the dashboard-deploy-logs branch Jan 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.