Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes #844

Merged
merged 5 commits into from Jan 27, 2015

Conversation

Projects
None yet
4 participants
@lmars
Copy link
Member

commented Jan 27, 2015

No description provided.

lmars added some commits Jan 27, 2015

test: Reduce SSH connect timeout to 30s
The connection is usually established in ~3s, so a 30s timeout seems
reasonable enough.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Timeout DumpLogs after 60s
Some recent CI builds have stalled indefinitely trying to SSH to VMs to
dump logs, and there is no way to kill them gracefully.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Only run unit tests when appropriate
Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Don't assign host-local IPs to tap devices
This was causing duplicate routes to appear in the Linux route table
which was potentially causing SSH hangs.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Track VM network information
This is to aid in debugging networking issues in CI.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
}()
select {
case <-done:
case <-time.After(60 * time.Second):

This comment has been minimized.

Copy link
@warpfork

warpfork Jan 27, 2015

Contributor

This timeout covers all the log gather attempts at once... do we need the big one, if the timeout per ssh connection is now low?

This comment has been minimized.

Copy link
@titanous

titanous Jan 27, 2015

Member

The ssh timeout only covers the connect time, this covers execution time too.

This comment has been minimized.

Copy link
@warpfork

warpfork Jan 27, 2015

Contributor

OH.... so if the dialSSH call times out or errors once, it doesn't stop future runs from trying and timing out again. Maybe that's not the greatest behavior, maybe we should just set an "error and stop trying" flag for that? WDYT?

This comment has been minimized.

Copy link
@titanous

titanous Jan 27, 2015

Member

I think this is fine for now.

@warpfork

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2015

LGTM

2 similar comments
@titanous

This comment has been minimized.

Copy link
Member

commented Jan 27, 2015

LGTM

@archseer

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2015

LGTM

lmars added a commit that referenced this pull request Jan 27, 2015

@lmars lmars merged commit 1c193dc into master Jan 27, 2015

1 check was pending

continuous-integration/flynn The Flynn CI build is in progress
Details

@lmars lmars deleted the test-fixes branch Jan 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.