Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have a look at the line length fixes, if you think they are too difficult to read or make the code less-readible lets discuss. i think all that is needed is an additional file that configures the max-line-length parameter for flake8 (filename .flake8 in in the root dir i think).
additionally, all thats left is to fix the copyright errors. i've moved the legacy copright notice to the
LEGACY_COPYRIGHT
file in the root directory. there is a ROS2 tool for this called ament_copyright which can "auto-add" whatever license you want. I think we should keep the BSD3 clause license, and for the authors we can curate anAUTHORS
file which lists all people who have contributed to the project. what do you think?