Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/flake8 #6

Merged
merged 5 commits into from Jan 26, 2021
Merged

Fix/flake8 #6

merged 5 commits into from Jan 26, 2021

Conversation

flynneva
Copy link
Owner

  • fixed remaining flake8 errors including line length
  • fixed remaining pep257 errors

have a look at the line length fixes, if you think they are too difficult to read or make the code less-readible lets discuss. i think all that is needed is an additional file that configures the max-line-length parameter for flake8 (filename .flake8 in in the root dir i think).

additionally, all thats left is to fix the copyright errors. i've moved the legacy copright notice to the LEGACY_COPYRIGHT file in the root directory. there is a ROS2 tool for this called ament_copyright which can "auto-add" whatever license you want. I think we should keep the BSD3 clause license, and for the authors we can curate an AUTHORS file which lists all people who have contributed to the project. what do you think?

@flynneva
Copy link
Owner Author

flynneva commented Jan 19, 2021

i've gone ahead and replaced all the exceptions with the single custom TransmissionException we have already defined. I think for most of the try/catches this works...but I could be wrong.

I also added a small bit to the README for anyone else who wants to run the flake8 locally.

bno055/bno055.py Outdated Show resolved Hide resolved
bno055/bno055.py Outdated Show resolved Hide resolved
bno055/params/NodeParameters.py Show resolved Hide resolved
bno055/params/NodeParameters.py Outdated Show resolved Hide resolved
@whatis777
Copy link
Collaborator

LGTM

@flynneva flynneva merged commit 21ce3a0 into develop Jan 26, 2021
@flynneva flynneva deleted the fix/flake8 branch January 28, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants