This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add support for GateNode with signal and sleep condition #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8 tasks
|
cc @kumare3 @EngHabu the only thing I am not sure on here is configuration of the output variable name from a signal. All the binding lookups are performed using input variable names into the actual written protobuf results. In these cases it seems like flytekit may use the python variable name? Does it make sense to set the Signal variable name in the proto? |
hamersaw
changed the title
Signed-off-by: Flyte-Bot <admin@flyte.org>
Signed-off-by: Flyte-Bot <admin@flyte.org>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
…propeller into flyte-bot-update-flyteidl
Signed-off-by: Flyte-Bot <admin@flyte.org>
…propeller into flyte-bot-update-flyteidl
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
…tput Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
…racking in gate node status Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
hamersaw
force-pushed
the
feature/gate-nodes
branch
from
d5a031f
to
c844a9c
Compare
2 tasks
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
wild-endeavor
approved these changes
Dec 1, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Update flyteidl version Signed-off-by: Flyte-Bot <admin@flyte.org> * Update flyteidl version Signed-off-by: Flyte-Bot <admin@flyte.org> * Fix build break Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update flyteidl version Signed-off-by: Flyte-Bot <admin@flyte.org> * added GateNode to compiler Signed-off-by: Daniel Rammer <daniel@union.ai> * added gate node handler Signed-off-by: Daniel Rammer <daniel@union.ai> * enable reading and setting gate node state Signed-off-by: Daniel Rammer <daniel@union.ai> * gate nodes working Signed-off-by: Daniel Rammer <daniel@union.ai> * changed Conditional to Condition in proto naming Signed-off-by: Daniel Rammer <daniel@union.ai> * passing admin client to gate node handler Signed-off-by: Daniel Rammer <daniel@union.ai> * using signal service client to check for signal in admin and write output Signed-off-by: Daniel Rammer <daniel@union.ai> * updated comments Signed-off-by: Daniel Rammer <daniel@union.ai> * completed implementation Signed-off-by: Daniel Rammer <daniel@union.ai> * added unit tests for gate node Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed unit tests with missing signal mocks Signed-off-by: Daniel Rammer <daniel@union.ai> * added docs on gate node handler Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * updating flyteidl dependency Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issue Signed-off-by: Daniel Rammer <daniel@union.ai> * added output variable name to signal condition Signed-off-by: Daniel Rammer <daniel@union.ai> * using last attempt started at timestamp on node context rather than tracking in gate node status Signed-off-by: Daniel Rammer <daniel@union.ai> * updated GateNodeStatus mocks Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issue Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> * updated flyteidl deps Signed-off-by: Daniel Rammer <daniel@union.ai> * update flyteidl deps Signed-off-by: Daniel Rammer <daniel@union.ai> * added interface validation for approve condition Signed-off-by: Daniel Rammer <daniel@union.ai> * added approve condition unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed missed merge conflict updating to slice of dial options Signed-off-by: Daniel Rammer <daniel@union.ai> * update generated mocks Signed-off-by: Dan Rammer <daniel@union.ai> Signed-off-by: Flyte-Bot <admin@flyte.org> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Dan Rammer <daniel@union.ai> Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adding support for GateNodes. These nodes block execution of the downstream based on a condition. Initially, we will implement sleeping, which block for a predefined duration, and manual signals, which require a user to notify that execution may proceed. Signals may also carry values, so a user can pass a variable which may be used in downstream nodes.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#208
Follow-up issue
NA