Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare minimum to support adoption of Flyway 9.22.0 #91

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

dkichler
Copy link
Contributor

@dkichler dkichler commented Sep 13, 2023

This PR introduces support for Flyway 9.22.0. It does not bring the plugin up to parity on any new features introduced since 7.4.0, but did need to align with a couple of configuration changes introduced:

  • The move to validate patterns instead of independent flags for ingoring certain types of migrations
  • Changing the default value for cleanDisabled configuration property from false to true

(both ☝️ introduced in Flyway 9.0.0)

Addresses #90

…ge in default clean disabled configuration property (changed in Flyway 9.0.0)
…re library, ensure the type provided is mutable/supports put
@dkichler
Copy link
Contributor Author

@davidmweber Would appreciate your take on this.

@mkurz
Copy link

mkurz commented Jan 15, 2024

Any news?

@davidmweber davidmweber merged commit 7bea2da into flyway:master Feb 5, 2024
@dkichler
Copy link
Contributor Author

dkichler commented Feb 5, 2024

@davidmweber I'd be happy to help with maintenance on this plugin, if you're open to sharing that burden, and given the appropriate privileges.

@davidmweber
Copy link
Collaborator

davidmweber commented Feb 5, 2024 via email

@kittsville
Copy link

If Flyway are not responding it could be worth forking to a repo under one of you two's GitHub accounts. I've seen other Scala libraries move when the parent org stopped maintaining them. The maven artifact is already published under david's namespace, which solves the more difficult part of getting users to update their build files.

@dkichler
Copy link
Contributor Author

dkichler commented Feb 5, 2024

If Flyway are not responding it could be worth forking to a repo under one of you two's GitHub accounts. I've seen other Scala libraries move when the parent org stopped maintaining them. The maven artifact is already published under david's namespace, which solves the more difficult part of getting users to update their build files.

I'd certainly be in favour of taking whatever steps necessary to bring this fully under control of maintainers. However, if going that route, I think the most logical place for it would be under the sbt org, where it can continue to live on as maintainers come and go. It would require having folks shuffle their dependency org upon a new release, but let's be honest that's gonna be the easiest step of any such process!

@dkichler dkichler deleted the version-upgrade branch February 5, 2024 14:07
@dkichler
Copy link
Contributor Author

dkichler commented Feb 5, 2024

@davidmweber

My problem is I don't have control
over the repo as it is owned and managed by Flyway (and their owner,
Redgate) but I have been singularly unable to contact them.

Do you have the ability to cut new releases? or is that something that must also be handled by Redgate?

@davidmweber
Copy link
Collaborator

davidmweber commented Feb 6, 2024 via email

@dkichler
Copy link
Contributor Author

dkichler commented Apr 4, 2024

Curious if you might have any cycles to cut a release of this @davidmweber ? or blocked otherwise?

@mkurz
Copy link

mkurz commented Apr 17, 2024

Good news everyone, I contacted the Flyway team at Redgate and we are about to move this repo to the sbt organisation soon:

@davidmweber
Copy link
Collaborator

davidmweber commented Apr 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants