Flyway should not expect "org/flywaydb/core/internal/version.txt" to be on the custom classpath

[dukeyin]

If I try to run Flyway 3.2.1 in OSGi and set a different ClassLoader into Flyway, then flyway.migrate() will fail immediately because VersionPrinter requires that an "org/flywaydb/core/internal/version.txt" exists.

[axelfontaine]

What OSGi container are you using? Our tests pass just fine in Equinox.

Cheers
Axel

[dukeyin]

I am currently running in Eclipse, but I believe this issue would happen in any OSGi container.

If I do something as simple as

Flyway flyway = new Flyway();
flyway.setClassLoader(getClass().getClassLoader()); // this tells Flyway to use my Bundle's ClassLoader, as opposed to Flyway's ClassLoader, because my SQL scripts are inside my Bundle, not Flyway's
flyway.setDataSource(dataSource);
flyway.migrate();

Then Flyway will always fail because of

flyway/flyway-core/src/main/java/org/flywaydb/core/Flyway.java

Line 1373 in 43ca80c

VersionPrinter.printVersion(classLoader);

existing:

Caused by: org.flywaydb.core.api.FlywayException: Unable to obtain
inputstream for resource: org/flywaydb/core/internal/version.txt
    at org.flywaydb.core.internal.util.scanner.classpath.ClassPathResource.loadAsString(ClassPathResource.java:84)
    at org.flywaydb.core.internal.util.VersionPrinter.printVersion(VersionPrinter.java:44)
    at org.flywaydb.core.Flyway.execute(Flyway.java:1373)
    at org.flywaydb.core.Flyway.migrate(Flyway.java:1006)

This is because Flyway is expecting "org/flywaydb/core/internal/version.txt" to exist within the custom ClassLoader.

If I instead have Flyway use its own ClassLoader, then of course Flyway can find "org/flywaydb/core/internal/version.txt" within the Flyway JAR, but it will never find my SQL scripts in a different bundle.

[axelfontaine]

Thanks for investigating. That was incredibly helpful. Consider this fixed in time for the next release.

Cheers
Axel

[Andy-L]

FWIW I am having the same issue running in Felix. Is there a workaround or a recommended alternate approach?

[okharkovskyi]

Same issue in Felix

[brianduguid]

I'm using Felix. Has a work-around been discovered yet?

[dukeyin]

For now, it would seem that your SQL migrations must be in the same bundle as Flyway (stored in a fragment hosted by org.flywaydb.core, for example).

[brianduguid]

Thank you.

[axelfontaine]

Fixed.

[andrehil]

Could you please release this fix in version 3?