Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single connection in DriverDataSource can never be closed #1042

Closed
mbosecke opened this issue Jun 30, 2015 · 1 comment
Closed

Single connection in DriverDataSource can never be closed #1042

mbosecke opened this issue Jun 30, 2015 · 1 comment

Comments

@mbosecke
Copy link

@mbosecke mbosecke commented Jun 30, 2015

I believe there is a bug in the DriverDataSource that prevents a "singleConnection" from ever being closed. My understanding is that you are typically suppressing the closing of this connection because the rest of flyway assumes there are actually two connections. However, when the entire data source is being closed there is a line of code that is explicitly trying to close the single connection but I believe this is still being caught by the SuppressCloseHandler.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 28, 2015

Excellent catch! Fixed.

axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Oct 28, 2015
@axelfontaine axelfontaine added this to the Flyway 4.0 milestone Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants