Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration with Flyway.setPlaceholderReplacement(false) fails with "org.flywaydb.core.api.FlywayException: No value provided for placeholder expressions" #1043

Closed
lukosan opened this issue Jul 2, 2015 · 1 comment
Labels
Milestone

Comments

@lukosan
Copy link

@lukosan lukosan commented Jul 2, 2015

The fix for #945 causes an exception to be thrown when running Flyway.migrate() because the method in PlaceholderReplacer which checks whether there are unmatched placeholders (checkForUnmatchedPlaceholderExpression) will match every char in the String, resulting in:

Exception in thread "main" org.flywaydb.core.api.FlywayException: No value provided for placeholder expressions: , , !, ", #, $, %, &, ', (, ), *, +, ,, -, ., /, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, :, ;, <, =, >, ?, @, A, B, C, D, E, F, G, H, I, J, K, L, M, N, O, P, Q, R, S, T, U, V, W, X, Y, Z, [, ], _, a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z, {, |, }, ~. Check your configuration!

lukosan pushed a commit to lukosan/flyway that referenced this issue Jul 2, 2015
@axelfontaine axelfontaine added this to the Flyway 4.0 milestone Oct 2, 2015
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Oct 2, 2015
axelfontaine added a commit that referenced this issue Oct 2, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 2, 2015

Thank you Luke! I ended fixing this slightly differently than your PR, but it wouldn't have been this easy hadn't you provided the testcase and done the investigation.

Cheers
Axel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.