Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using both custom and SQL callbacks #1047

Closed
barryoneill opened this issue Jul 5, 2015 · 2 comments
Closed

Using both custom and SQL callbacks #1047

barryoneill opened this issue Jul 5, 2015 · 2 comments
Labels
Milestone

Comments

@barryoneill
Copy link

@barryoneill barryoneill commented Jul 5, 2015

If I specify

flyway.callbacks=com.myclass.CustomCallBack

it gets called fine, but I notice it seems to suppress the SQL callback functionality. Is there any way to have both? I notice there's a SqlScriptFlywayCallback that could be potentially used to enable SQL callbacks as well as the custom one - but that's one of your 'internal' classes and can't be used directly without some wrapper code..

Alternatively, even just a clarification in the documentation that you can generally only use one or the other by default would be fine, I found this out by experimentation.

Thanks!

@axelfontaine axelfontaine added this to the Flyway 4.0 milestone Oct 3, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 3, 2015

I agree, there is certainly room for improvement here.

axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Feb 2, 2016
@barryoneill
Copy link
Author

@barryoneill barryoneill commented Feb 3, 2016

Thanks for the work on this, I look forward to trying it out soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.