Regression in multiline comments/quotes handling #1264
Closed
Labels
Milestone
Comments
Thanks! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Flyway are you using?
4.0
What database are you using (type & version)?
Oracle 11g / 12c
What operating system are you using?
Windows 7
What did you do?
After updating to flyway 4.0 some stored procedures started to fail compilation when updated through flyway.
Managed to track problem to following
Test script to reproduce the issue
the problem seems to be:
parser splits
'/*comment with,comma'
into several tokens, one of them is'/*comment
when it is handled by following piece of code inside
SqlStatementBuilder
' is ignored and as a result number of quotes is uneven.
which ultimately leads to
PLS-00103: Encountered the symbol "/" The symbol "/" was ignored.
Suggestions
modify method
protected String simplifyLine(String line)
inSqlStatementBuilder
to add spaces around quotes(both ' and alternative) and may be around multiline comments /* */or consider using regex to find required special tokens instead of splitting string
The text was updated successfully, but these errors were encountered: