Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean does not delete procedures on case sensitive SQLServer #1292

Closed
mrjeffjohnston opened this issue Apr 25, 2016 · 2 comments
Closed

Clean does not delete procedures on case sensitive SQLServer #1292

mrjeffjohnston opened this issue Apr 25, 2016 · 2 comments

Comments

@mrjeffjohnston
Copy link
Contributor

@mrjeffjohnston mrjeffjohnston commented Apr 25, 2016

What version of Flyway are you using?

4.0

What database are you using (type & version)?

SQL Server 2012. Database collation is Latin1_General_CS_AS

What operating system are you using?

Windows

What did you do?

mvn flyway:clean

What did you expect to see?

That all procedures would be deleted in the managed schema.

What did you see instead?

No procedures were deleted.

The issue is caused by the call cleanRoutines("procedure") within SQLServerSchema. In the INFORMATION_SCHEMA.ROUTINES table the ROUTINE_TYPE column is upper case. The call needs to be changed to cleanRoutines("PROCEDURE"). Other parts of the class may have similar case issues.

@mrjeffjohnston
Copy link
Contributor Author

@mrjeffjohnston mrjeffjohnston commented Apr 27, 2016

Submitted pull request #1297 to fix

@axelfontaine axelfontaine added this to the Flyway 4.0.1 milestone May 5, 2016
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue May 5, 2016
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented May 5, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.