Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if user is set in Flyway config, but password is only present in settings.xml #1300

Closed
cowwoc opened this issue Apr 27, 2016 · 1 comment
Closed
Labels
Milestone

Comments

@cowwoc
Copy link

@cowwoc cowwoc commented Apr 27, 2016

What version of Flyway are you using?

4.0

What database are you using (type & version)?

AWS Aurora (MySQL 5.6)

What operating system are you using?

Windows 7, 64bit

What did you do?

In pom.xml:

                        <configuration>
                            <user>someUser</user>
                            <serverId>myServerId</serverId>
                        </configuration>

In settings.xml:

    <servers>
        <server>
            <id>myServerId</id>
            <password>somePassword</password>
        </server>
    </servers>
What did you expect to see?

I expect the username to be taken from pom.xml and password from settings.xml because I only need to hide the password, not the username.

Alternatively (since it's probably best to specify both in the same place) Flyway should issue an error message when encountering this case.

What did you see instead?

The username from pom.xml is used, but the password in settings.xml is ignored.

@axelfontaine axelfontaine changed the title Ability to push password into settings.xml but keep username in pom.xml Fail if user is set in Flyway config, but password is only present in settings.xml May 6, 2016
axelfontaine added a commit that referenced this issue May 6, 2016
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented May 6, 2016

Error message added.

axelfontaine added a commit to flyway/flywaydb.org that referenced this issue May 6, 2016
@axelfontaine axelfontaine added this to the Flyway 4.0.1 milestone May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.