Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate does not respect target #1554

Closed
masc3d opened this issue Mar 14, 2017 · 4 comments
Closed

validate does not respect target #1554

masc3d opened this issue Mar 14, 2017 · 4 comments

Comments

@masc3d
Copy link

@masc3d masc3d commented Mar 14, 2017

What version of Flyway are you using?

4.1.2

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

Verified against command line and gradle plugin

What database are you using (type & version)?

mysql

What operating system are you using?

macos

What did you do?
  • migrate without target set (applying all migrations)
  • validate with flyway.target set to a lower version and flyway.ignoreFutureMigrations=false
What did you expect to see?

Validate should fail.

What did you see instead?

Validate completes successfully as long as future migrations can be found. flyway.target is ignored.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Apr 27, 2017

This doesn't strictly fall under the current definition of future as future currently means higher than the highest version resolved on the classpath or filesystem.

I am however not opposed to revisit the meaning of feature for 5.0 to mean higher than target.

@masc3d
Copy link
Author

@masc3d masc3d commented Apr 27, 2017

Then the current definition is flawed, as it doesn't make much sense as soon as target is set.

@axelfontaine axelfontaine changed the title validate does not respect target when ignoreFutureMigrations is set to false validate does not respect target Nov 30, 2017
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Nov 30, 2017
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 30, 2017

The definition of future is actually consistent and correct.

However, we have now changed validate to ignore anything above target, which is more consistent with the definition of target.

@masc3d
Copy link
Author

@masc3d masc3d commented Nov 7, 2019

I am however not opposed to revisit the meaning of feature for 5.0 to mean higher than target.

I suppose we missed that one. I still believe it's worth changing this for the better.

anyway as it seems, it's now also broken for future migrations not being on the classpath as of 6.0.8.

please re-open @axelfontaine

dohrayme pushed a commit to dohrayme/flyway that referenced this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.