Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percona XtraDB Cluster support #1556

Closed
raffig opened this issue Mar 15, 2017 · 12 comments
Closed

Percona XtraDB Cluster support #1556

raffig opened this issue Mar 15, 2017 · 12 comments

Comments

@raffig
Copy link

@raffig raffig commented Mar 15, 2017

I'm using Flywaydb 4.1.2 and JavaAPI.

I'm using Percona XtraDB Cluster, which I know is not directly supported by flywaydb, however as it is a drop-in replacement for MySQL I've been using it without problem in version 3.2.1. Recently I've decided to upgrade to flywaydb 4.2.1. However tests showed that new version uses GET_LOCK while 'migrate' which is forbidden in Percona (message: Percona-XtraDB-Cluster prohibits use of GET_LOCK with pxc_strict_mode = ENFORCING).

However, because it worked correctly with version 3.2.1 I thought that maybe it would be easy to fix this issue?

Limitation is described here:
https://www.percona.com/doc/percona-xtradb-cluster/5.7/features/pxc-strict-mode.html

I've tested this against Percona XtraDB Cluster 5.7.16. In case it helps somehow there is easy to use Docker for such tests (I did use it too):
https://hub.docker.com/r/percona/percona-xtradb-cluster/

Best regards!

@axelfontaine axelfontaine changed the title Flywaydb 4.1.2 does not work with Percona XtraDB Cluster Percona XtraDB Cluster support Mar 15, 2017
@lchayoun
Copy link

@lchayoun lchayoun commented Apr 28, 2017

Working fine with version 4.0.3
Facing the issue as well since 4.1.0

@regevbr
Copy link

@regevbr regevbr commented May 18, 2017

same issue here

@miken700
Copy link

@miken700 miken700 commented Jul 28, 2017

This appears to have been introduced in bab1fbb . Specifically the move to use named locks in mysql rather than locking on the meta data table. See the added lock method override in MySQLDbSupport in that commit.

Would it make sense to fall back to table locking for mysql percona strict mode users? Although this might break the case that this commit was intended for, for percona strict users, it could allow for migration of existing DB's.

@charlarz
Copy link

@charlarz charlarz commented Aug 11, 2017

Same issue here with "RELEASE_LOCK":
“level”:“ERROR”,“description”:“Unable to release MySQL named lock: Flyway--1511746474",“type”:“log”,“roletype”:“saevnt”,“data_version”:“2",“correlation_id”:“”,“logger”:“org.flywaydb.core.internal.dbsupport.mysql.MySQLNamedLockTemplate”,“method”:“error”,“line”:“56",“sa-events_data”:{“message_code”:“Unable to release MySQL named lock: Flyway--1511746474”},“stack_trace”:“j.sql.SQLException: Percona-XtraDB-Cluster prohibits use of RELEASE_LOCK with pxc_strict_mode = ENFORCING\n\tat

Has anyone tried changing the PXC_STRICT_MODE as a workaround?

@picaron
Copy link

@picaron picaron commented Nov 3, 2017

Facing the same issue with Percona 5.7 and Flyway 4.2.0

@tomaszglinski
Copy link

@tomaszglinski tomaszglinski commented Apr 23, 2018

Hi, is there a chance for some hotfix? It affects a lot of people. The 5.1.0 is scheduled in theory to 8. May, will it really be included?

@axelfontaine axelfontaine removed this from the Flyway 5.1.0 milestone May 23, 2018
@axelfontaine axelfontaine added this to the Flyway 5.2.0 milestone May 23, 2018
@roberthunt
Copy link

@roberthunt roberthunt commented May 24, 2018

We have encountered this issue as well and it is preventing us from updating Flyway, would it be viable to add an option to disable the table locking functionality?

@tomaszglinski
Copy link

@tomaszglinski tomaszglinski commented May 24, 2018

Sorry guys, looks like we will need to switch to liquibase, since there is nothing going on around this blocker (though it is marked as "feature"..)

@roberthunt
Copy link

@roberthunt roberthunt commented May 24, 2018

As @miken700 mentioned, this issue was introduced by a commit to fix #1067

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented May 24, 2018

This is now firmly on the roadmap for 5.2.0. As part of this effort we will integrate XtraDB test instances in our test environment and officially support this configuration from then on. Until then sticking with Flyway 4.0.3 for this specific scenario is your best choice.

oharsta added a commit to OpenConext/OpenConext-attribute-aggregation that referenced this issue Jun 23, 2018
Downgraded Flyway 4.0.3 as described as the solution in
flyway/flyway#1556 until it is fixed in
upcoming version 5.2.0.
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Sep 26, 2018
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Sep 26, 2018

Support for Percona XtraDB Cluster 5.7 has been implemented. This configuration is automatically detected and the locking strategy is automatically adjusted accordingly.

@picaron
Copy link

@picaron picaron commented Sep 28, 2018

@axelfontaine into which release is this feature going to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants