Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on incorrect parameter instead of showing a warning #1577

Closed
teopost opened this issue Mar 28, 2017 · 3 comments
Closed

Fail on incorrect parameter instead of showing a warning #1577

teopost opened this issue Mar 28, 2017 · 3 comments

Comments

@teopost
Copy link

@teopost teopost commented Mar 28, 2017

What version of Flyway are you using?

4.1.1

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

Command-line

What database are you using (type & version)?

Oracle 11r2

What operating system are you using?

Mac OSX Sierra

What did you do?

(Please include the content causing the issue, any relevant configuration settings, and the command you ran)

+---------------------+-------------------------------------+---------------------+---------+
| Version             | Description                         | Installed on        | State   |
+---------------------+-------------------------------------+---------------------+---------+
| 1.0.0.20170327.1108 | new Sequences                       |                     | Pending |
| 1.0.0.20170327.1109 | new Tables                          |                     | Pending |
| 2.0.0.20170327.1130 | new Functions                       |                     | Pending |
| 2.0.0.20170327.1150 | cust view Utenti                    |                     | Pending |
| 2.0.0.20170327.1151 | cust view V TALKS ISCRITTI          |                     | Pending |
| 2.0.0.20170327.1152 | cust view V TALKS ISCR 2017 T0201   |                     | Pending |
| 2.0.0.20170327.1155 | add dataora spedizioni              |                     | Pending |
| 2.0.0.20170327.1200 | drop comunicazioni id on spedizioni |                     | Pending |
+---------------------+-------------------------------------+---------------------+---------+
flyway -configFile=conf/dallas-flyway_test-bocconi.cfg  -taget=2.0.0.20170327.1151  migrate

I used a wrong parameter. taget instead of ```target````

What did you expect to see?

Flyway report an error because taget parameter is unknow and the migration are not applyed

What did you see instead?

Flyway apply all migrations !

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 28, 2017

Hmm this should actually be checked...

@axelfontaine axelfontaine added this to the Flyway 4.2.0 milestone Mar 28, 2017
@teopost
Copy link
Author

@teopost teopost commented Mar 28, 2017

Flyway shows the message WARNING: Unknown configuration properties: flyway.target` but migrations are applied

https://asciinema.org/a/6q6m84saohacpmq8tadcwfpbn

@axelfontaine axelfontaine added t: feature and removed t: bug labels Mar 28, 2017
@axelfontaine axelfontaine changed the title Flyway does not report an error with incorrect command-line parameters Fail on incorrect parameter instead of showing a warning Mar 28, 2017
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 27, 2017

Good point. I agree that in the spirit of fail fast this should be an error.

axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Nov 27, 2017
dohrayme pushed a commit to dohrayme/flyway that referenced this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.