Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCallbacks inconsistent deprecation warning #2169

Closed
snicoll opened this issue Oct 11, 2018 · 1 comment
Closed

setCallbacks inconsistent deprecation warning #2169

snicoll opened this issue Oct 11, 2018 · 1 comment

Comments

@snicoll
Copy link

@snicoll snicoll commented Oct 11, 2018

Which version and edition of Flyway are you using?

5.2.0

If this is not the latest version, can you reproduce the issue with the latest one as well?

(Many bugs are fixed in newer releases and upgrading will often resolve the issue)

Yes

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

Java API

Which database are you using (type & version)?

N/A

Which operating system are you using?

N/A

What did you do?

(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)

Nothing specific

What did you expect to see?

Calling setCallbacks is deprecated according to the Javadoc in favour of Flyway.configure so the warning message should reference this method rather than a reference to an already deprecated method.

What did you see instead?

Flyway.setCallbacks(FlywayCallback) has been deprecated and will be removed in Flyway 6.0. Use Flyway.setCallbacks(Callback) instead.

@snicoll snicoll changed the title setCallbacks inconsistent deprecating warning setCallbacks inconsistent deprecation warning Oct 11, 2018
@axelfontaine axelfontaine added this to the Flyway 5.2.1 milestone Oct 11, 2018
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Oct 11, 2018
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 11, 2018

Good catch! We actually had a number of cases like this, which have now all been fixed.

dohrayme pushed a commit to dohrayme/flyway that referenced this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.