Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback output doesn't match execution order #2260

Closed
esauser opened this issue Jan 11, 2019 · 3 comments

Comments

@esauser
Copy link

commented Jan 11, 2019

Which version and edition of Flyway are you using?

5.2.4

If this is not the latest version, can you reproduce the issue with the latest one as well?

(Many bugs are fixed in newer releases and upgrading will often resolve the issue)

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

Command-line

Which database are you using (type & version)?

MSSQL 2014

Which operating system are you using?

Linux

What did you do?

(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
Created a beforeEachMigrate and afterEachMigrate SQL callback and ran Flyway Migrate with a pending migration.

What did you expect to see?

I expected to see no feedback about the callback or for the before to output before the migration and the after to output after the migration.

What did you see instead?

Both came after the migration.
image

Despite the display, they do execute in the correct order and perform as expected.

Also, the list for every migration. As you know from #2256, we are using Flyway to execute tests. We just added this to wrap each of them in a transaction (per our on-going conversation) and now the output has tripped with all of these entries. It also would be nice if these were just listed once globally at the top instead of every time.

@axelfontaine

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Thanks for reporting. Could you share your flyway.conf file (no database url, user or password)?

@esauser

This comment has been minimized.

Copy link
Author

commented Jan 17, 2019

flyway.txt

The following environment variables are also set:

  • FLYWAY_VALIDATE_ON_MIGRATE: false
  • FLYWAY_LOCATIONS: filesystem:test
  • FLYWAY_GROUP: true

@axelfontaine axelfontaine added this to the Flyway 6.0.0 milestone Feb 11, 2019

axelfontaine pushed a commit to flyway/flywaydb.org that referenced this issue Jun 5, 2019
@axelfontaine

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

The order was indeed not very logical from an outsider's perspective. We have now adjusted to more closely match the user mental model.

@axelfontaine axelfontaine changed the title Callback output doesn't match execution order and results in noisy output Callback output doesn't match execution order Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.