Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cockroach 19.x support #2445

Closed
rkettelerij opened this issue Jul 25, 2019 · 3 comments

Comments

@rkettelerij
Copy link

@rkettelerij rkettelerij commented Jul 25, 2019

Which version and edition of Flyway are you using?

Flyway Community Edition 5.2.4 by Boxfuse

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

Via Spring Boot, so the Java API

Which database are you using (type & version)?

CockroachDB 19.1

Which operating system are you using?

macOS

What did you do?

Start a flyway migration against CockroachDB 19.1

What did you expect to see?

No warning.

What did you see instead?

A warning saying: Flyway upgrade recommended: CockroachDB 19.1 is newer than this version of Flyway and support has not been tested.

Note that the migration ran fine. No issues at all. So this ticket is purely about the warning message.

Update: https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/database/cockroachdb/CockroachDBDatabase.java#L66

@juliahayward juliahayward changed the title Validate against Cockroach 19.x Cockroach 19.x support Jul 25, 2019
@juliahayward juliahayward added this to the Someday-Maybe milestone Jul 25, 2019
@juliahayward

This comment has been minimized.

Copy link
Member

@juliahayward juliahayward commented Oct 3, 2019

We've run all our existing tests against 19.1 and all pass. We're currently talking to Cockroach about issues around retries that exist in older versions of Flyway; if you see any problems in that regard, please do raise a new issue.

@juliahayward

This comment has been minimized.

Copy link
Member

@juliahayward juliahayward commented Oct 3, 2019

Fixed in 6.0.5.

@juliahayward

This comment has been minimized.

Copy link
Member

@juliahayward juliahayward commented Nov 15, 2019

Just to add to this, we've pulled the 19.2 Docker image and tested against that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.